fix: bump default superchain images #1799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delivlib has some places where it defaults to a particular superchain image, which may grow outdated over time. This came up specifically in the context of ECR mirroring recently. Bump the Superchain image we're using to a recent one everywhere (`bookworm` instead of `bullseye`, a more recent Node because Node 18 is about to be deprecated). Also make sure that all CodeBuild projects have reasonable descriptions, because we have hundreds in our account now and we need some way to tell them apart.
Signed-off-by: github-actions <[email protected]>
otaviomacedo
reviewed
Dec 9, 2024
| @@ -36,7 +37,7 @@ describe('EcrMirror', () => { | |||
| Value: '123aass:password-key:AWSCURRENT', | |||
| }, | |||
| ], | |||
| Image: 'public.ecr.aws/jsii/superchain:1-bullseye-slim-node18', | |||
| Image: DEFAULT_SUPERCHAIN_IMAGE, | |||
There was a problem hiding this comment.
Are we really testing anything here, now? If we set DEFAULT_SUPERCHAIN_IMAGE to "some-nonsensical-string", it will still pass.
There was a problem hiding this comment.
True. Copying the string there feels just as useless, but I can do it I suppose
…m:cdklabs/aws-delivlib into huijbers/descriptions-and-superchain-bump
iliapolo
approved these changes
Dec 10, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
delivlib has some places where it defaults to a particular superchain image, which may grow outdated over time. This came up specifically in the context of ECR mirroring recently.
Bump the Superchain image we're using to a recent one everywhere (
bookworminstead ofbullseye, a more recent Node because Node 18 is about to be deprecated).Also make sure that all CodeBuild projects have reasonable descriptions, because we have hundreds in our account now and we need some way to tell them apart.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.