chore: upgrade minNodeVersion to 18+ #1550
Conversation
| @@ -22,7 +22,7 @@ jobs: | |||
| - name: Setup Node.js | |||
| uses: actions/setup-node@v3 | |||
There was a problem hiding this comment.
Looks like we are duplicating work: #1551
You should be upgrading setup-node and checkout versions as well.
There was a problem hiding this comment.
Sorry. Do you want to take over? On your PR, it looks like you manually updated the files whereas you'll need to update the projenrc.ts file for any changes to stick.
There was a problem hiding this comment.
These versions are controlled by projen. I don't think they are necessary to fix the broken workflow atm
There was a problem hiding this comment.
There isn't much to take over here...
A little confused why projen is needed here but it's how it is setup.
The error (which I can't find anymore) said checkout and node actions needed upgrading to node v20. Which I don't think CDK even supports.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.