fix: sign.sh incorrectly uses relative path of nuget package instead of absolute path for signing operations
#1478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Francis <[email protected]>
Signed-off-by: Francis <[email protected]>
rix0rrr
approved these changes
Oct 13, 2023
| @@ -21,12 +21,13 @@ fi | |||
| found=false | |||
| for nuget_package_path in $(find dotnet -name *.nupkg -not -iname *.symbols.nupkg); do | |||
| found=true | |||
| echo "🔑 Applying authenticode signatures to assemblies in ${nuget_package_path}" | |||
| for file in $(unzip -Z1 ${nuget_package_path} '*.dll'); do | |||
| nuget_package=$(cd $(dirname ${nuget_package_path}) && echo $PWD)/$(basename ${nuget_package_path}) | |||
There was a problem hiding this comment.
It looks like what you're trying to do is make this path absolute.
Most Linuxes will have the tool realpath to do this (won't exist on Mac by default though), and according to StackOverflow you can use readlink -f <file> as well.
There was a problem hiding this comment.
Noted - thanks for explaining that and showing me an alternative!
colifran
changed the title
sign.sh incorrectly uses nuget package path instead of nuget package for signing operationssign.sh incorrectly uses relative path of nuget package instead of absolute path for signing operations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sign.shwas incorrectly using the relative nuget package path rather than the absolute nuget package path for signing operations. This was causing the signing process to exit with status 12. This PR corrects this mistake by getting the absolute nuget package path via the following code:By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.