feat: sign stage for NuGet code signing with AWS Signer #1466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Francis <[email protected]>
Signed-off-by: Francis <[email protected]>
Signed-off-by: Francis <[email protected]>
Signed-off-by: Francis <[email protected]>
Signed-off-by: Francis <[email protected]>
Signed-off-by: Francis <[email protected]>
Signed-off-by: Francis <[email protected]>
Signed-off-by: Francis <[email protected]>
rix0rrr
requested changes
Oct 5, 2023
Signed-off-by: Francis <[email protected]>
Signed-off-by: Francis <[email protected]>
Signed-off-by: Francis <[email protected]>
Signed-off-by: Francis <[email protected]>
Signed-off-by: Francis <[email protected]>
rix0rrr
approved these changes
Oct 6, 2023
Signed-off-by: Francis <[email protected]>
colifran
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we (the AWS CDK team) sign
.nupkgfiles usinglib/publishing/nuget/sign.shwith certificates we maintain in our cdk-ops repo. We received guidance from another internal AWS team that this no longer conforms with AWS best practice.The new mechanism for code signing
.nupkgfiles will be carried out using AWS Signer with infrastructure set up in a signing account. This PR adds a signing stage feature and a newsign.shscript that will be used to interact with our signing account to code sign.nupkgfiles.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.