-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(release): 1.0.0-beta.6 #514
Conversation
Your pull request will be updated and merged automatically (do not update manually). |
@eladb The build is failing because the integration test snapshots are now missing the imports of:
Apparently this no longer takes affect: The CRD's themselves are hosted here: https://doc.crds.dev/raw/github.com/crossplane/[email protected]. And indeed they do not have a top level |
I think this might be related to: crdsdev/doc@fee7e2b#diff-d3a059d47a8abdf6c9b6971f64d4ec9089ef3ac63bb2de55089fba18832f67b7 |
That import is currently broken - not because of a change in `cdk8s` but rather a change in the schema of the crds on the site. This shouldn't be failing our builds and we should reconsider this as a build time dependency. See #514 (comment) *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
/cc @hasheddan |
@iliapolo apologies for the break here. This has to do with the fact that CRDs are now being stored with internal representation, so those metadata fields are stripped off, but all of the same information is technically available. That endpoint could be updated to return with |
@hasheddan So all of the objects currently returned by the endpoint will always have the same GVK? |
@iliapolo yes that is correct, it will only return
I assume this will be most convenient for you? If not, happy to support other variations :) |
@hasheddan yes that would be great. I also think it would be more aligned with standard k8s resource definitions, making it easier for other tools to consume as well. Thanks! |
@iliapolo great :) Should be fixed https://doc.crds.dev/raw/github.com/crossplane/crossplane |
Feel free to tag me on anything if you are seeing issues in the future 👍 |
@hasheddan sweet, thanks! :) |
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license