-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: migrate from k8s.gcr.io to registry.k8s.io #1172
chore: migrate from k8s.gcr.io to registry.k8s.io #1172
Conversation
@mrgrain can you PTAL? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, thank you for your contribution. Just a minor comment.
Looks like build is failing for mutation since this was originated from a fork. Could you update your branch?
|
Signed-off-by: Waleed Malik <[email protected]>
Hey, @ahmedwaleedmalik, our build step cannot run on a fork. Could you run |
Not sure what you want from me here? Do you want me to build it and check if it's working? Then yes, i was able to build it. |
Hey @ahmedwaleedmalik, we have taken care of this issue and would be closing this PR now. We thank you for your contribution and bringing visibility into this. Really appreciate it. :) |
So the maintainers didn't bother to reply for a month and then just closed the PR. Seems like you folks are very "open source" friendly. |
Kubernetes is migrating its image registry from k8s.gcr.io to registry.k8s.io.
Part of kubernetes/k8s.io#4780.