Python the-basic-mq #112
Merged
Python the-basic-mq #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| subdomain_name = 'mq' | ||
|
|
||
| # Request and issue a certificate for the subdomain (iot.cdkexample.com in this example) beforehand, and paste ARN. | ||
| cert_arn = 'arn:aws:acm:us-east-1:2XXXXXX9:certificate/exxxx8-xxxx-xxxx-xxxx-fxxxxxxxx9' |
There was a problem hiding this comment.
The TS version creates the cert for you, what made you change it?
There was a problem hiding this comment.
With DnsValidatedCertificate CDK creates a different cert for the same domain when you delete and re-deploy the stack. You can issue 20 certs per year (aws/aws-cdk#5889) on new AWS accounts, and I thought it is better to manually issue a cert and use it by ARN.
There was a problem hiding this comment.
Is it worth adding a comment to that effect? Linking to that issue
There was a problem hiding this comment.
I agree, I had better add some comment on it.
6293
commented
Aug 30, 2020
| # However, be careful of ACM yearly certificate limit. | ||
| # You will bump into the error after you destroy/deploy the stack over and over again. | ||
| # See https://github.com/aws/aws-cdk/issues/5889 for the details. | ||
| cert = acm.Certificate.from_certificate_arn(self, 'cert', certificate_arn=cert_arn) |
There was a problem hiding this comment.
Added some comment here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I added Python example of
the-basic-mqpattern.Thank you.