-
-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Extendable fileUploader #248 #464
base: master
Are you sure you want to change the base?
Conversation
remove unused imports
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Haruki-Mortis this looks pretty good.
that said, i'm still mulling over whether this is the right way to handle it
can you describe again why we need pre and post middleware?
also, please let me know if you have any thoughts on how this could be handled without requiring pre and post middleware. i understand this may not be possible and (if possible) may require a significant overhaul. that said, now that you've been in the code, you likely have a decent idea of what is and isn't possible. im hoping you might also have thoughts on how file upload might reimagined, so that it can be simpler
thanks a lot for this PR.
@Haruki-Mortis @cdimascio I don't want to be bound to multer.any()(req, res, next) {...}. we can do: options.multOpts.uploadHandler(req, res, next) {...} This is straightforward to implement and gives the user the ability to use multer without restrictions. I have already implemented and tested this approach exemplary, works fine. What do you say? Is this worth a PR? |
@Haruki-Mortis good idea. this will provide good flexibility |
Hello, any news on this ? |
@devthejo I support the idea and welcome PRs. |
Feature: Extendable fileUploader #248