Updated headers for every possible ZSoft .pcx header #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes bit plane depth from .pcx format, replaces it with headers that should match any possible variant (there are a lot)
Every possible .pcx header combination now added, removed other .pcx entries scattered elsewhere so they are all together
Merged
cdgriffith
added a commit
that referenced
this pull request
Feb 23, 2024
- Adding #50 details for ZSoft .pcx files (thanks to Andy - NebularNerd) - Adding #51 details for JXL files (thanks to Andy - NebularNerd) - Adding #54 missing py.typed file (thanks to Raphaël Vinot) - Fixing #53 magic data for GIF images (thanks to Andy - NebularNerd) --------- Co-authored-by: Raphaël Vinot <[email protected]> Co-authored-by: Andy <[email protected]>
This was referenced May 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ZSoft .pcx files have lots of possible header combinations depending on the version and other attributes. because it's quite a small header I've added all 40 possible versions based on https://en.wikipedia.org/wiki/PCX. This will provide (hopefully) 100% confidence against any .pcx file you'll come across.
I've extended the naming to cover the various types, equally happy to remove/amend the stuff in
( )if you feel it's too much.