Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to fix the pixbuf problem. #109

Merged
merged 2 commits into from
Mar 9, 2019
Merged

Conversation

cdepillabout
Copy link
Owner

Try to fix the pixbuf problem from #107.

@jtojnar
Copy link

jtojnar commented Mar 9, 2019

I do not think this will help for NixOS/nixpkgs#54278. The issue is caused by mismatch between the gdk-pixbuf the project is linked against and the loaders picked up from GDK_PIXBUF_MODULE_FILE environment variable. And wrapGAppsHook should already take care of wrapping all executables with the correct variable.

@jtojnar
Copy link

jtojnar commented Mar 9, 2019

Right, you are overriding the buildCommand therefore the envHooks necessary for gdk-pixbuf setup hook will not run.

You could try to set it manually but I would just suggest to rely on the default builder. Something like

dontBuild = true;
unpackPhase = ":";
installPhase = ''
  runHook preInstall
  mkdir -p $out/bin
  ln -sf ${env}/bin/termonad $out/bin/termonad
  runHook postInstall
'';

instead of the buildCommand.

@jtojnar
Copy link

jtojnar commented Mar 9, 2019

There is also some kind of interaction between setup hooks and cross-compilation offsets making the example above no work: NixOS/nixpkgs#56943

@cdepillabout
Copy link
Owner Author

@jtojnar Thanks for the info! That is very helpful.

@craigem @romanofski I added an additional commit to this PR (0846a8f) fixing up the build as suggested by @jtojnar. Could you try it out and see if it fixes your problem with Termonad segfaulting?

@romanofski
Copy link

Seems to be working for me. I tried c1d136b and yep, still segfaults. So 0846a8f seems to do the trick. Is this a workaround until NixOS/nixpkgs#56943 is fixed?

@jtojnar
Copy link

jtojnar commented Mar 9, 2019

The gdk_pixbuf insertion is the workaround, the rest is normal – we do not recommend overriding builder unless you are fine with and none of the generic builder procedures and setup hooks working.

@cdepillabout
Copy link
Owner Author

Okay, since this seems to be working, I will go ahead and merge it in.

@romanofski Thanks for your help with trying out various things. I'm glad we finally got this working for you.

@jtojnar Thanks for the suggestion to stop overriding the builder!

@cdepillabout cdepillabout merged commit f0747ab into master Mar 9, 2019
@cdepillabout cdepillabout deleted the try-to-fix-pixbuf-problem branch March 9, 2019 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants