Making xmlError js friendly. #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gotama
commented
Oct 29, 2020
| @@ -24,9 +24,7 @@ void set_numeric_field(Local<Object> obj, const char *name, const int value) { | |||
| Local<Value> BuildSyntaxError(xmlError *error) { | |||
| Nan::EscapableHandleScope scope; | |||
|
|
|||
| Local<Value> err = | |||
| Exception::Error(Nan::New<String>(error->message).ToLocalChecked()); | |||
| Local<Object> out = Local<Object>::Cast(err); | |||
There was a problem hiding this comment.
The reason I removed this, because casting err to the out object is the reason the formatting for JS broke.
A stack trace doesn't fit nicely into a key value JS object. Im trying to think of a more elegant way to append a stack trace. Will update if I come up with anything.
There was a problem hiding this comment.
Also error->message might not be a stack trace, as im using that as xsd validation error messages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With regards to #2