[CDAP-21046][CDAP-21048] Fixing flow control metrics on startup: #15737
+157
−63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ritwiksahani
force-pushed
the
CDAP-21046
branch
2 times, most recently
from
b3ee8fe
to
9936444
Compare
tivv
reviewed
Nov 18, 2024
...c/src/main/java/io/cdap/cdap/internal/app/services/ProgramNotificationSubscriberService.java
Outdated
Show resolved
Hide resolved
cdap-app-fabric/src/main/java/io/cdap/cdap/internal/app/services/RunRecordMonitorService.java
Outdated
Show resolved
Hide resolved
ritwiksahani
force-pushed
the
CDAP-21046
branch
2 times, most recently
from
59deeb7
to
dff5da9
Compare
itsankit-google
approved these changes
Nov 19, 2024
ritwiksahani
force-pushed
the
CDAP-21046
branch
from
dff5da9
to
dad1d23
Compare
|
tivv
approved these changes
Nov 19, 2024
ritwiksahani
force-pushed
the
CDAP-21046
branch
2 times, most recently
from
426f3ad
to
3e29800
Compare
ritwiksahani
force-pushed
the
CDAP-21046
branch
from
3e29800
to
902acf4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the following bugs:
launching and running count metrics are calculated incorrectly on service restarts.
Moving the logic to launch active runs and compute metrics to non sharded main class
ProgramNotificationSubscriberService.Also publishing launching count metric on every cleanup not just when records are removed.
On startup the latest metrics are recomputed and published as well.
Testing
Launching pipeline :
Post restart:
Post completion: