Add HTTP Basic Auth option to OAuthHandler #15729
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itsankit-google
requested changes
Nov 5, 2024
|
|
||
| public OAuthProvider(String name, | ||
| String loginURL, | ||
| String tokenRefreshURL, | ||
| @Nullable OAuthClientCredentials clientCreds) { | ||
| @Nullable OAuthClientCredentials clientCreds, | ||
| @Nullable CredentialEncodingStrategy strategy) { |
There was a problem hiding this comment.
usually constructors are meant to be private if the builder class exists for objects.
There was a problem hiding this comment.
Changing this seems outside the scope of my PR though
...etl/cdap-data-pipeline-base/src/main/java/io/cdap/cdap/datapipeline/oauth/OAuthProvider.java
Outdated
Show resolved
Hide resolved
...tl/cdap-data-pipeline-base/src/main/java/io/cdap/cdap/datapipeline/service/OAuthHandler.java
Outdated
Show resolved
Hide resolved
...tl/cdap-data-pipeline-base/src/main/java/io/cdap/cdap/datapipeline/service/OAuthHandler.java
Outdated
Show resolved
Hide resolved
...tl/cdap-data-pipeline-base/src/main/java/io/cdap/cdap/datapipeline/service/OAuthHandler.java
Show resolved
Hide resolved
...tl/cdap-data-pipeline-base/src/main/java/io/cdap/cdap/datapipeline/service/OAuthHandler.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.