Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚸 Python Bindings for NA State Preparation #556

Merged
merged 119 commits into from
Nov 18, 2024
Merged

🚸 Python Bindings for NA State Preparation #556

merged 119 commits into from
Nov 18, 2024

Conversation

ystade
Copy link
Contributor

@ystade ystade commented Nov 15, 2024

Description

This PR aims to provide python bindings for the state preparation for neutral atoms part of qmap.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

ystade and others added 30 commits July 25, 2024 08:40
…icly already in a depending target

Signed-off-by: burgholzer <[email protected]>
@ystade
Copy link
Contributor Author

ystade commented Nov 17, 2024

Thanks a lot for your efforts to find that bug. I added now the required sanity checks for the solve function.

Copy link

codecov bot commented Nov 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.6%. Comparing base (ba4d08f) to head (e7abb4b).
Report is 121 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main    #556   +/-   ##
=====================================
  Coverage   90.5%   90.6%           
=====================================
  Files         91      93    +2     
  Lines      10784   10803   +19     
  Branches    1831    1832    +1     
=====================================
+ Hits        9769    9789   +20     
+ Misses      1015    1014    -1     
Flag Coverage Δ
cpp 90.3% <100.0%> (+<0.1%) ⬆️
python 96.0% <100.0%> (+<0.1%) ⬆️
Files with missing lines Coverage Δ
include/na/nasp/Solver.hpp 95.0% <ø> (ø)
src/mqt/qmap/na/__init__.py 100.0% <100.0%> (ø)
src/mqt/qmap/na/state_preparation.py 100.0% <100.0%> (ø)
src/na/nasp/CodeGenerator.cpp 91.4% <100.0%> (+0.2%) ⬆️
src/na/nasp/Solver.cpp 91.7% <100.0%> (+0.1%) ⬆️

... and 1 file with indirect coverage changes

Copy link
Member

@burgholzer burgholzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, especially on all the documentation! Many thanks for that!

I have nothing more to complain about 😉
The inline comments should hopefully fix the mypy warning and a copy and paste error.

docs/DevelopmentGuide.rst Outdated Show resolved Hide resolved
src/mqt/qmap/pyqmap.pyi Outdated Show resolved Hide resolved
@burgholzer burgholzer marked this pull request as ready for review November 17, 2024 23:19
burgholzer and others added 3 commits November 17, 2024 18:20
@ystade ystade merged commit 716b21b into main Nov 18, 2024
28 checks passed
@ystade ystade deleted the wip-smt-na-python branch November 18, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python Anything related to Python code usability Anything related to usability
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants