-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🚸 Python Bindings for NA State Preparation #556
Conversation
Signed-off-by: burgholzer <[email protected]>
Signed-off-by: burgholzer <[email protected]>
…icly already in a depending target Signed-off-by: burgholzer <[email protected]>
Signed-off-by: burgholzer <[email protected]>
Signed-off-by: burgholzer <[email protected]>
Thanks a lot for your efforts to find that bug. I added now the required sanity checks for the solve function. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #556 +/- ##
=====================================
Coverage 90.5% 90.6%
=====================================
Files 91 93 +2
Lines 10784 10803 +19
Branches 1831 1832 +1
=====================================
+ Hits 9769 9789 +20
+ Misses 1015 1014 -1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, especially on all the documentation! Many thanks for that!
I have nothing more to complain about 😉
The inline comments should hopefully fix the mypy warning and a copy and paste error.
Signed-off-by: Lukas Burgholzer <[email protected]>
Signed-off-by: Lukas Burgholzer <[email protected]>
Description
This PR aims to provide python bindings for the state preparation for neutral atoms part of qmap.
Checklist: