Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error propagation. #283

Merged
merged 1 commit into from
Sep 16, 2024
Merged

Fix error propagation. #283

merged 1 commit into from
Sep 16, 2024

Conversation

pehamTom
Copy link
Member

@pehamTom pehamTom commented Sep 16, 2024

Description

There is an error in the computation of fault sets in state preparation circuits. Sometimes, the gates are not traversed in the correct topological order, and thus, some faults are not correct. This didn't show up before because the faults were still caught by the verification circuits.

Fixes # (issue)

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

@pehamTom pehamTom self-assigned this Sep 16, 2024
@pehamTom pehamTom added the bug Something isn't working label Sep 16, 2024
Copy link

codecov bot commented Sep 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.5%. Comparing base (3cf545e) to head (7ad1ccc).
Report is 68 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #283     +/-   ##
=======================================
- Coverage   83.6%   83.5%   -0.1%     
=======================================
  Files         49      49             
  Lines       4159    4153      -6     
  Branches     372     372             
=======================================
- Hits        3477    3471      -6     
  Misses       682     682             
Flag Coverage Δ *Carryforward flag
cpp 83.6% <ø> (ø) Carriedforward from 3cf545e
python 83.5% <100.0%> (-0.1%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
src/mqt/qecc/ft_stateprep/state_prep.py 71.9% <100.0%> (-0.3%) ⬇️

@pehamTom pehamTom merged commit c4ae4b8 into main Sep 16, 2024
27 checks passed
@pehamTom pehamTom deleted the topological-order branch September 16, 2024 11:29
@burgholzer burgholzer added fix Fix for something that isn't working and removed bug Something isn't working labels Sep 16, 2024
Copy link
Collaborator

@lucasberent lucasberent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Fix for something that isn't working
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

3 participants