Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add representation for general stabilizer codes to the python side. #278

Merged
merged 8 commits into from
Sep 5, 2024

Conversation

pehamTom
Copy link
Member

@pehamTom pehamTom commented Sep 4, 2024

Description

Currently QECC only has support for CSS codes. This PR adds general stabilizer codes and reactors the current classes to reflect this structure.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

@burgholzer burgholzer added enhancement Enhancement to existing feature refactor Changes the refactor the code base labels Sep 4, 2024
Copy link

codecov bot commented Sep 4, 2024

Codecov Report

Attention: Patch coverage is 96.79144% with 6 lines in your changes missing coverage. Please review.

Project coverage is 83.4%. Comparing base (28075c7) to head (cf2e5eb).
Report is 111 commits behind head on main.

Files with missing lines Patch % Lines
src/mqt/qecc/codes/stabilizer_code.py 95.7% 6 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #278     +/-   ##
=======================================
+ Coverage   82.7%   83.4%   +0.6%     
=======================================
  Files         46      47      +1     
  Lines       3978    4100    +122     
  Branches     353     353             
=======================================
+ Hits        3292    3420    +128     
+ Misses       686     680      -6     
Flag Coverage Δ *Carryforward flag
cpp 83.3% <ø> (ø) Carriedforward from 444be7b
python 83.4% <96.7%> (+1.0%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
src/mqt/qecc/__init__.py 100.0% <100.0%> (ø)
src/mqt/qecc/codes/__init__.py 100.0% <100.0%> (ø)
src/mqt/qecc/codes/css_code.py 87.5% <100.0%> (+6.6%) ⬆️
src/mqt/qecc/codes/hexagonal_color_code.py 100.0% <100.0%> (ø)
src/mqt/qecc/codes/square_octagon_color_code.py 97.2% <100.0%> (ø)
src/mqt/qecc/codes/stabilizer_code.py 95.7% <95.7%> (ø)

src/mqt/qecc/codes/css_code.py Fixed Show fixed Hide fixed
src/mqt/qecc/codes/stabilizer_code.py Fixed Show fixed Hide fixed
src/mqt/qecc/codes/stabilizer_code.py Fixed Show fixed Hide fixed
@pehamTom pehamTom marked this pull request as ready for review September 4, 2024 14:58
@pehamTom pehamTom requested a review from lucasberent September 4, 2024 14:58
@pehamTom pehamTom self-assigned this Sep 4, 2024
lucasberent
lucasberent previously approved these changes Sep 5, 2024
Copy link
Collaborator

@lucasberent lucasberent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just some minor comments

src/mqt/qecc/codes/css_code.py Show resolved Hide resolved
src/mqt/qecc/codes/css_code.py Show resolved Hide resolved
src/mqt/qecc/codes/stabilizer_code.py Show resolved Hide resolved
@pehamTom pehamTom merged commit 7efadbf into main Sep 5, 2024
24 checks passed
@pehamTom pehamTom deleted the concatenated-codes branch September 5, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement to existing feature refactor Changes the refactor the code base
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants