-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Infrastructure Update without Windows Support #270
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: burgholzer <[email protected]>
Signed-off-by: burgholzer <[email protected]>
Signed-off-by: burgholzer <[email protected]>
Signed-off-by: burgholzer <[email protected]>
Signed-off-by: burgholzer <[email protected]>
Signed-off-by: burgholzer <[email protected]>
Signed-off-by: burgholzer <[email protected]>
Signed-off-by: burgholzer <[email protected]>
Signed-off-by: burgholzer <[email protected]>
Signed-off-by: burgholzer <[email protected]>
Signed-off-by: burgholzer <[email protected]>
Signed-off-by: burgholzer <[email protected]>
Signed-off-by: burgholzer <[email protected]>
Signed-off-by: burgholzer <[email protected]>
Signed-off-by: burgholzer <[email protected]>
burgholzer
added
enhancement
Enhancement to existing feature
dependencies
Pull requests that update a dependency file
github_actions
Pull requests that update GitHub Actions code
continuous integration
Anything related to the CI setup
packaging
Anything related to Python packaging
python
Pull requests that update Python code
code quality
Code quality improvements
labels
Aug 28, 2024
Signed-off-by: burgholzer <[email protected]>
Signed-off-by: burgholzer <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #270 +/- ##
=======================================
+ Coverage 82.4% 82.7% +0.2%
=======================================
Files 46 46
Lines 3997 3978 -19
Branches 362 353 -9
=======================================
- Hits 3296 3292 -4
+ Misses 701 686 -15
|
lgtm, thanks! we can also update with #271? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
code quality
Code quality improvements
continuous integration
Anything related to the CI setup
dependencies
Pull requests that update a dependency file
enhancement
Enhancement to existing feature
github_actions
Pull requests that update GitHub Actions code
packaging
Anything related to Python packaging
python
Pull requests that update Python code
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR pulls out the changes from #266 that do not involve setting up Windows CI and building Windows wheels.
Since it might be a while before that will be resolved, it's better to just move on with the changes here for now.
This includes:
The PR also contains some miscellaneous fixes and smaller code improvements.
Checklist: