Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Infrastructure Update without Windows Support #270

Merged
merged 17 commits into from
Aug 28, 2024

Conversation

burgholzer
Copy link
Member

@burgholzer burgholzer commented Aug 28, 2024

Description

This PR pulls out the changes from #266 that do not involve setting up Windows CI and building Windows wheels.
Since it might be a while before that will be resolved, it's better to just move on with the changes here for now.

This includes:

  • Shipping experimental Python 3.13 support (including the free threaded variant)
  • Updating scikit-build-core to 0.10
  • Updating pybind11 to 2.13
  • Updating MQT Core to 2.6.1 (development version)
  • Reinstantiating proper Python warning filters
  • Updating pre-commit hooks to their latest versions and updating the respective configuration
  • ... probably a couple more things that I just missed ...

The PR also contains some miscellaneous fixes and smaller code improvements.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

@burgholzer burgholzer added enhancement Enhancement to existing feature dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code continuous integration Anything related to the CI setup packaging Anything related to Python packaging python Pull requests that update Python code code quality Code quality improvements labels Aug 28, 2024
@burgholzer burgholzer self-assigned this Aug 28, 2024
Copy link

codecov bot commented Aug 28, 2024

Codecov Report

Attention: Patch coverage is 86.15385% with 9 lines in your changes missing coverage. Please review.

Project coverage is 82.7%. Comparing base (c4209c7) to head (ca3d56c).
Report is 130 commits behind head on main.

Files with missing lines Patch % Lines
...alog_information_decoding/simulators/simulation.py 42.8% 4 Missing ⚠️
src/mqt/qecc/ft_stateprep/state_prep.py 88.0% 3 Missing ⚠️
src/DecodingSimulator.cpp 83.3% 1 Missing ⚠️
src/Utils.cpp 0.0% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #270     +/-   ##
=======================================
+ Coverage   82.4%   82.7%   +0.2%     
=======================================
  Files         46      46             
  Lines       3997    3978     -19     
  Branches     362     353      -9     
=======================================
- Hits        3296    3292      -4     
+ Misses       701     686     -15     
Flag Coverage Δ
cpp 83.3% <71.4%> (+0.7%) ⬆️
python 82.3% <87.9%> (-0.1%) ⬇️
Files with missing lines Coverage Δ
include/DecodingSimulator.hpp 0.0% <ø> (ø)
include/ecc/Ecc.hpp 92.5% <ø> (ø)
include/ecc/Id.hpp 100.0% <ø> (ø)
include/ecc/Q18Surface.hpp 100.0% <ø> (ø)
include/ecc/Q3Shor.hpp 66.6% <ø> (ø)
include/ecc/Q5Laflamme.hpp 75.0% <ø> (ø)
include/ecc/Q7Steane.hpp 100.0% <ø> (ø)
include/ecc/Q9Shor.hpp 75.0% <ø> (ø)
include/ecc/Q9Surface.hpp 100.0% <ø> (ø)
src/ecc/Ecc.cpp 95.4% <ø> (+4.1%) ⬆️
... and 16 more

@lucasberent lucasberent mentioned this pull request Aug 28, 2024
4 tasks
@lucasberent
Copy link
Collaborator

lgtm, thanks! we can also update with #271?

@burgholzer
Copy link
Member Author

lgtm, thanks! we can also update with #271?

Let's get this merged first, then rebase #271.
I'll review that later 😎

@burgholzer burgholzer merged commit 172a381 into main Aug 28, 2024
31 of 33 checks passed
@burgholzer burgholzer deleted the infrastructure-update-without-windows branch August 28, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality Code quality improvements continuous integration Anything related to the CI setup dependencies Pull requests that update a dependency file enhancement Enhancement to existing feature github_actions Pull requests that update GitHub Actions code packaging Anything related to Python packaging python Pull requests that update Python code
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants