Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🩹 disentangle mqt-core-dd and mqt-core-algo #670

Merged
merged 3 commits into from
Aug 14, 2024

Conversation

burgholzer
Copy link
Member

Description

This PR is a follow-up to #668 and fixes an overlooked dependency of the mqt-core-dd library on the mqt-core-algo library that somehow went unnoticed in the original PR.
To this end, this PR reverts parts of #452 and moves the respective benchmarking code to the evaluation target.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

@burgholzer burgholzer added refactor Anything related to code refactoring fix Fix for something that isn't working DD Anything related to the DD package c++ Anything related to C++ code labels Aug 13, 2024
@burgholzer burgholzer self-assigned this Aug 13, 2024
Copy link

codecov bot commented Aug 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.0%. Comparing base (2662795) to head (e2a9287).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #670     +/-   ##
=======================================
- Coverage   92.0%   92.0%   -0.1%     
=======================================
  Files        127     125      -2     
  Lines      13911   13809    -102     
  Branches    2177    2171      -6     
=======================================
- Hits       12810   12707    -103     
- Misses      1101    1102      +1     
Flag Coverage Δ *Carryforward flag
cpp 91.7% <ø> (-0.1%) ⬇️
python 99.7% <ø> (ø) Carriedforward from 298debf

*This pull request uses carry forward flags. Click here to find out more.

see 2 files with indirect coverage changes

@burgholzer burgholzer merged commit 21da251 into main Aug 14, 2024
21 checks passed
@burgholzer burgholzer deleted the disentangle-dd-and-algo-targets branch August 14, 2024 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Anything related to C++ code DD Anything related to the DD package fix Fix for something that isn't working refactor Anything related to code refactoring
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant