Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚸 make dd/Package.hpp export dd/Package_fwd.hpp #640

Merged
merged 2 commits into from
Jul 1, 2024
Merged

Conversation

burgholzer
Copy link
Member

Description

This PR slighlty improves the usability of the IWYU features of clang-tidy for the DD package. To this end, it marks the dd/Package_fwd.hpp include in the dd/Package.hpp header as an export. This way, header need not include both headers, but can only import the dd/Package.hpp header to also get the content of the foward declaration header.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

@burgholzer burgholzer self-assigned this Jul 1, 2024
@burgholzer burgholzer added usability Anything related to usability code quality Code quality improvements DD Anything related to the DD package c++ Anything related to C++ code labels Jul 1, 2024
Signed-off-by: burgholzer <[email protected]>
@burgholzer burgholzer enabled auto-merge (squash) July 1, 2024 18:59
@burgholzer burgholzer merged commit 78a8d6b into main Jul 1, 2024
34 checks passed
@burgholzer burgholzer deleted the better-dd-iwyu branch July 1, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Anything related to C++ code code quality Code quality improvements DD Anything related to the DD package usability Anything related to usability
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant