Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🩹 make sure to use the install rpath for build #626

Merged
merged 1 commit into from
Jun 5, 2024
Merged

Conversation

burgholzer
Copy link
Member

Description

This avoids codesign issues under macOS which does not allow to load libraries that have been tampered with, e.g., by modifying the rpath information during installation

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

this avoids codesign issues under macOS which does not allow to load libraries that have been tampered with, e.g., by modifying the rpath information during installation
@burgholzer burgholzer self-assigned this Jun 5, 2024
@burgholzer burgholzer added fix Fix for something that isn't working c++ Anything related to C++ code labels Jun 5, 2024
@burgholzer burgholzer merged commit f95c27e into main Jun 5, 2024
34 checks passed
@burgholzer burgholzer deleted the install-rpath branch June 5, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Anything related to C++ code fix Fix for something that isn't working
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant