-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎨🚨 Improved formatting and linting config #625
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: burgholzer <[email protected]>
Signed-off-by: burgholzer <[email protected]>
Signed-off-by: burgholzer <[email protected]>
Signed-off-by: burgholzer <[email protected]>
Signed-off-by: burgholzer <[email protected]>
Signed-off-by: burgholzer <[email protected]>
Signed-off-by: burgholzer <[email protected]>
Context: pypa/setuptools-scm#806 Signed-off-by: burgholzer <[email protected]>
burgholzer
added
dependencies
Pull requests that update a dependency file
code quality
Code quality improvements
continuous integration
Anything related to the CI setup
labels
Jun 5, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #625 +/- ##
=====================================
Coverage 91.6% 91.6%
=====================================
Files 148 148
Lines 14736 14738 +2
Branches 2365 2365
=====================================
+ Hits 13504 13507 +3
+ Misses 1232 1231 -1
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
code quality
Code quality improvements
continuous integration
Anything related to the CI setup
dependencies
Pull requests that update a dependency file
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a couple further pre-commit checks and other utilities to ensure the validity of certain configs.
This includes:
pre-commit
check for checking several schemata for their correctness, such as dependabot and GitHub actions.editorconfig
file for enabling wide spread support for proper formatting out of the boxcodespell
to thetypos
spellchecker that is more comprehensive and a lot fastervalidate-pyproject
check that makes sure thepyproject.toml
is validChecklist: