Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

♻️ simplify reusable Python CI workflow #591

Merged
merged 2 commits into from
Apr 19, 2024
Merged

♻️ simplify reusable Python CI workflow #591

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
997579f
♻️ simplify reusable Python CI workflow
burgholzer Apr 18, 2024
dc9983d
🩹 fix needs condition
burgholzer Apr 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 10 additions & 17 deletions .github/workflows/reusable-python-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,18 +43,11 @@ jobs:
uses: rui314/setup-mold@v1
- uses: hynek/build-and-inspect-python-package@v2
id: baipp
outputs:
python-versions: ${{ steps.baipp.outputs.supported_python_classifiers_json_array }}

max-python-version:
name: 🐍 Determine maximum supported Python version
needs: dist
runs-on: ubuntu-latest
steps:
# use jq to get the last element of the array
- run: echo "max-python-version=$(echo '${{ needs.dist.outputs.python-versions }}' | jq --raw-output '.[-1]')" >> $GITHUB_OUTPUT
- name: 🐍 Determine maximum supported Python version
run: echo "max-python-version=$(echo '${{ steps.baipp.outputs.supported_python_classifiers_json_array }}' | jq --raw-output '.[-1]')" >> $GITHUB_OUTPUT
id: max-python-version
outputs:
python-versions: ${{ steps.baipp.outputs.supported_python_classifiers_json_array }}
max-python-version: ${{ steps.max-python-version.outputs.max-python-version }}

python-tests-ubuntu:
Expand All @@ -75,17 +68,17 @@ jobs:

python-tests-macos:
name: 🍎 ${{ matrix.python-version }} ${{ matrix.runs-on }}
needs: [dist, max-python-version]
needs: [dist]
strategy:
fail-fast: false
matrix:
python-version:
- ${{ fromJson(needs.dist.outputs.python-versions)[0] }}
- ${{ needs.max-python-version.outputs.max-python-version }}
- ${{ needs.dist.outputs.max-python-version }}
runs-on: [macos-13] # test Intel architecture
include:
- runs-on: macos-14 # test Apple Silicon architecture
python-version: ${{ needs.max-python-version.outputs.max-python-version }} # testing Apple Silicon on 3.8 is blocked by https://github.com/actions/setup-python/issues/808
python-version: ${{ needs.dist.outputs.max-python-version }} # testing Apple Silicon on 3.8 is blocked by https://github.com/actions/setup-python/issues/808
uses: ./.github/workflows/reusable-python-tests.yml
with:
runs-on: ${{ matrix.runs-on }}
Expand All @@ -97,13 +90,13 @@ jobs:

python-tests-windows:
name: 🏁 ${{ matrix.python-version }}
needs: [dist, max-python-version]
needs: [dist]
strategy:
fail-fast: false
matrix:
python-version:
- ${{ fromJson(needs.dist.outputs.python-versions)[0] }}
- ${{ needs.max-python-version.outputs.max-python-version }}
- ${{ needs.dist.outputs.max-python-version }}
uses: ./.github/workflows/reusable-python-tests.yml
with:
runs-on: windows-latest
Expand All @@ -115,13 +108,13 @@ jobs:

minimums:
name: 🔧 Minimums
needs: [dist, max-python-version]
needs: [dist]
strategy:
fail-fast: false
matrix:
python-version:
- ${{ fromJson(needs.dist.outputs.python-versions)[0] }}
- ${{ needs.max-python-version.outputs.max-python-version }}
- ${{ needs.dist.outputs.max-python-version }}
uses: ./.github/workflows/reusable-python-minimums.yml
with:
runs-on: ubuntu-latest
Expand Down
Loading