Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ internalize private methods of the circuit optimizer #585

Merged
merged 1 commit into from
Apr 14, 2024

Conversation

burgholzer
Copy link
Member

Description

This PR internalizes all the private/protected methods in the circuit optimizer.
There is hardly any use in exposing them, so it's fine to just define them in the source file.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

@burgholzer burgholzer added refactor Anything related to code refactoring code quality Code quality improvements Core Anything related to the Core library and IR c++ Anything related to C++ code labels Apr 14, 2024
@burgholzer burgholzer added this to the MQT Core milestone Apr 14, 2024
@burgholzer burgholzer self-assigned this Apr 14, 2024
@burgholzer burgholzer enabled auto-merge (squash) April 14, 2024 18:11
Copy link

codecov bot commented Apr 14, 2024

Codecov Report

Attention: Patch coverage is 89.81481% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 91.3%. Comparing base (868849c) to head (bcc48c1).

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main    #585   +/-   ##
=====================================
  Coverage   91.3%   91.3%           
=====================================
  Files        132     131    -1     
  Lines      14052   14052           
  Branches    2243    2243           
=====================================
  Hits       12841   12841           
  Misses      1211    1211           
Flag Coverage Δ
cpp 91.0% <89.8%> (ø)
python 99.5% <ø> (ø)
Files Coverage Δ
src/CircuitOptimizer.cpp 88.4% <89.8%> (+<0.1%) ⬆️

@burgholzer burgholzer merged commit 00fcfaa into main Apr 14, 2024
37 checks passed
@burgholzer burgholzer deleted the internalize-circuit-optimizer-privates branch April 14, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Anything related to C++ code code quality Code quality improvements Core Anything related to the Core library and IR refactor Anything related to code refactoring
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant