Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⏪ add MQT::CorePython target back #541

Merged
merged 2 commits into from
Jan 29, 2024
Merged

Conversation

burgholzer
Copy link
Member

Description

As the integration of the mqt-core Python package into the top-level tools turned out to be a much lengthier process than imagined, this PR adds back the MQT::CorePython target that was previously used to read in Qiskit objects.
This should allow development in the top-level libraries to continue without waiting for the remaining issues with the Python package being resolved.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

@burgholzer burgholzer added fix Fix for something that isn't working Core Anything related to the Core library and IR c++ Anything related to C++ code labels Jan 29, 2024
@burgholzer burgholzer self-assigned this Jan 29, 2024
@burgholzer burgholzer marked this pull request as ready for review January 29, 2024 14:46
Signed-off-by: burgholzer <[email protected]>
Copy link
Contributor

Cpp-Linter Report ⚠️

Some files did not pass the configured checks!

clang-tidy reports: 1 concern(s)
  • include/mqt-core/python/qiskit/QuantumCircuit.hpp

    include/mqt-core/python/qiskit/QuantumCircuit.hpp:3:10: error: [clang-diagnostic-error]

    'pybind11/pybind11.h' file not found

    #include "pybind11/pybind11.h"
             ^~~~~~~~~~~~~~~~~~~~~

Have any feedback or feature suggestions? Share it here.

@burgholzer burgholzer merged commit 3d5e14b into main Jan 29, 2024
33 of 35 checks passed
@burgholzer burgholzer deleted the add-back-mqt-core-python branch January 29, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Anything related to C++ code Core Anything related to the Core library and IR fix Fix for something that isn't working
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant