♻️ Refactor NonUnitaryOperation class to simplify target handling
#399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the NonUnitaryOperation class, the previous implementation used two different vectors to manage the targets for Measure and other operations, which lead to redundancy in the code. This update unifies the handling of targets by using only one vector (named targets) for all operations. This simplification enhances the code readability and maintainability. It also removes the need of several functions like getTargets() and getUsedQubits(). Several function argument lists have also been refactored for cleaner and more consistent usage. Further, the print() function was restructured for better clarity. Overall, these changes will be beneficial for future development work. Signed-off-by: burgholzer <[email protected]>
burgholzer
added
refactor
Cpp-Linter Report ✔️No problems need attention. Have any feedback or feature suggestions? Share it here. |
Codecov Report
@@ Coverage Diff @@
## main #399 +/- ##
=======================================
- Coverage 89.3% 89.3% -0.1%
=======================================
Files 98 98
Lines 11655 11636 -19
Branches 2087 2085 -2
=======================================
- Hits 10413 10394 -19
Misses 1242 1242
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the NonUnitaryOperation class, the previous implementation used two different vectors to manage the targets for Measure and other operations, which lead to redundancy in the code. This update unifies the handling of targets by using only one vector (named targets) for all operations. This simplification enhances the code readability and maintainability. It also removes the need of several functions like getTargets() and getUsedQubits(). Several function argument lists have also been refactored for cleaner and more consistent usage. Further, the print() function was restructured for better clarity. Overall, these changes will be beneficial for future development work.
Checklist: