Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔥 Remove Snapshot and ShowProbabilities instructions from MQT Core #393

Merged
merged 2 commits into from
Aug 9, 2023

Conversation

burgholzer
Copy link
Member

Description

Removed the parsing and creation of Snapshot and ShowProbabilities instructions from QASMParser and NonUnitaryOperations due to their irrelevance within MQT Core. This eliminates unnecessary error checking and streamlining the codebase. NonUnitaryOperation no longer needs to account for Snapshot and ShowProbabilities, simplifying its logic. The operations were also removed from related files and tests to maintain consistency.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

Removed the parsing and creation of Snapshot and ShowProbabilities instructions from QASMParser and NonUnitaryOperations due to their irrelevance within MQT Core. This eliminates unnecessary error checking and streamlining the codebase. NonUnitaryOperation no longer needs to account for Snapshot and ShowProbabilities, simplifying its logic. The operations were also removed from related files and tests to maintain consistency.

Signed-off-by: Lukas Burgholzer <[email protected]>
@burgholzer burgholzer added refactor Anything related to code refactoring code quality Code quality improvements Core Anything related to the Core library and IR c++ Anything related to C++ code labels Aug 9, 2023
@burgholzer burgholzer added this to the MQT Core milestone Aug 9, 2023
@burgholzer burgholzer self-assigned this Aug 9, 2023
@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Merging #393 (84efd9e) into main (bd41474) will increase coverage by 0.1%.
Report is 1 commits behind head on main.
The diff coverage is 90.6%.

@@           Coverage Diff           @@
##            main    #393     +/-   ##
=======================================
+ Coverage   89.1%   89.2%   +0.1%     
=======================================
  Files         97      98      +1     
  Lines      11713   11661     -52     
  Branches    2098    2090      -8     
=======================================
- Hits       10445   10411     -34     
+ Misses      1268    1250     -18     
Files Changed Coverage Δ
include/operations/NonUnitaryOperation.hpp 100.0% <ø> (+2.5%) ⬆️
include/operations/OpType.hpp 89.4% <ø> (+3.6%) ⬆️
src/parsers/QASMParser.cpp 97.8% <ø> (+0.7%) ⬆️
src/CircuitOptimizer.cpp 84.0% <40.0%> (+<0.1%) ⬆️
include/dd/FunctionalityConstruction.hpp 100.0% <100.0%> (ø)
include/dd/Operations.hpp 83.5% <100.0%> (-0.1%) ⬇️
src/dd/Operations.cpp 100.0% <100.0%> (ø)
src/operations/NonUnitaryOperation.cpp 95.3% <100.0%> (+4.3%) ⬆️

... and 2 files with indirect coverage changes

Signed-off-by: Lukas Burgholzer <[email protected]>
@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2023

Cpp-Linter Report ✔️

No problems need attention.

Have any feedback or feature suggestions? Share it here.

@burgholzer burgholzer merged commit 5982ba7 into main Aug 9, 2023
46 checks passed
@burgholzer burgholzer deleted the remove-snapshot-and-show-probabilities branch August 9, 2023 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Anything related to C++ code code quality Code quality improvements Core Anything related to the Core library and IR refactor Anything related to code refactoring
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant