Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔥 Remove ToffoliTable from DD Package #380

Merged
merged 1 commit into from
Jul 12, 2023
Merged

Conversation

burgholzer
Copy link
Member

Description

Fixes #339

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

…erations

Deleted the ToffoliTable from the Package to eliminate unnecessary complexity. Additionally, simplified the handling of the X gate within Operations to further decrease complexity. This was possible as the ToffoliTable was only used in this location. The removal does not lead to a loss of information or functionality, only a simplification of the code structure.

Signed-off-by: Lukas Burgholzer <[email protected]>
@burgholzer burgholzer added refactor Anything related to code refactoring DD Anything related to the DD package c++ Anything related to C++ code labels Jul 12, 2023
@burgholzer burgholzer self-assigned this Jul 12, 2023
@github-actions
Copy link
Contributor

Cpp-Linter Report ✔️

No problems need attention.

Have any feedback or feature suggestions? Share it here.

@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

Merging #380 (e987bdd) into main (a6cc11b) will decrease coverage by 0.1%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##            main    #380     +/-   ##
=======================================
- Coverage   89.1%   89.0%   -0.1%     
=======================================
  Files         98      97      -1     
  Lines      11763   11708     -55     
  Branches    2108    2098     -10     
=======================================
- Hits       10485   10431     -54     
+ Misses      1278    1277      -1     
Impacted Files Coverage Δ
include/dd/Operations.hpp 83.9% <ø> (-0.5%) ⬇️
include/dd/Package.hpp 94.2% <ø> (-0.1%) ⬇️

@burgholzer burgholzer merged commit b1c49b9 into main Jul 12, 2023
46 checks passed
@burgholzer burgholzer deleted the remove-toffoli-table branch July 12, 2023 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Anything related to C++ code DD Anything related to the DD package refactor Anything related to code refactoring
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

⚗️ Remove the ToffoliTable from the DD Package
1 participant