✨ Removal of identity nodes in matrix DDs #358

aaronleesander · 2023-06-20T12:36:19Z

This pull request strips matrix DDs of their identities, representing them implicitly instead of explicitly.

This includes not constructing a gate DD for the full system size (i.e. a single qubit operation is expanded to n-qubit with identities), skipping nodes that resemble the identity, as well as handling skipped levels in operations such as multiplication and addition.

The identity is now represented by a single terminal node.

include/dd/Package.hpp

        if (x.p->isIdentity()) {
          if constexpr (n == NEDGE) {
            // additionally check if y is the identity in case of matrix
            // multiplication
            if (y.p->isIdentity()) {
-              e = makeIdent(start, var);
+              // e = makeIdent(start, var);


test/dd/test_package.cpp

+// TEST(DDPackageTest, expectationValueExceptions) {
+//   const dd::QubitCount nrQubits = 2;
+//
+//   auto dd = std::make_unique<dd::Package<>>(nrQubits);
+//   const auto zeroState =
+//       dd->makeZeroState(static_cast<dd::QubitCount>(nrQubits - 1));
+//   const auto xGate = dd->makeGateDD(dd::Xmat, nrQubits, 0);
+//
+//   EXPECT_ANY_THROW(dd->expectationValue(xGate, zeroState));
+// }


test/dd/test_package.cpp

+// TEST(DDPackageTest, Ancillaries) {
+//   auto dd = std::make_unique<dd::Package<>>(4);
+//   auto hGate = dd->makeGateDD(dd::Hmat, 2, 0);
+//   auto cxGate = dd->makeGateDD(dd::Xmat, 2, 0_pc, 1);
+//   auto bellMatrix = dd->multiply(cxGate, hGate);
+//
+//   dd->incRef(bellMatrix);
+//   auto reducedBellMatrix =
+//       dd->reduceAncillae(bellMatrix, {false, false, false, false});
+//   EXPECT_EQ(bellMatrix, reducedBellMatrix);
+//   dd->incRef(bellMatrix);
+//   reducedBellMatrix =
+//       dd->reduceAncillae(bellMatrix, {false, false, true, true});
+//   EXPECT_EQ(bellMatrix, reducedBellMatrix);
+//
+//   auto extendedBellMatrix = dd->extend(bellMatrix, 2);
+//   dd->incRef(extendedBellMatrix);
+//   reducedBellMatrix =
+//       dd->reduceAncillae(extendedBellMatrix, {false, false, true, true});
+//   EXPECT_TRUE(reducedBellMatrix.p->e[1].isZeroTerminal());
+//   EXPECT_TRUE(reducedBellMatrix.p->e[2].isZeroTerminal());
+//   EXPECT_TRUE(reducedBellMatrix.p->e[3].isZeroTerminal());
+//
+//   EXPECT_EQ(reducedBellMatrix.p->e[0].p->e[0].p, bellMatrix.p);
+//   EXPECT_TRUE(reducedBellMatrix.p->e[0].p->e[1].isZeroTerminal());
+//   EXPECT_TRUE(reducedBellMatrix.p->e[0].p->e[2].isZeroTerminal());
+//   EXPECT_TRUE(reducedBellMatrix.p->e[0].p->e[3].isZeroTerminal());
+//
+//   dd->incRef(extendedBellMatrix);
+//   reducedBellMatrix =
+//       dd->reduceAncillae(extendedBellMatrix, {false, false, true, true},
+//       false);
+//   EXPECT_TRUE(reducedBellMatrix.p->e[1].isZeroTerminal());
+//   EXPECT_TRUE(reducedBellMatrix.p->e[2].isZeroTerminal());
+//   EXPECT_TRUE(reducedBellMatrix.p->e[3].isZeroTerminal());
+//
+//   EXPECT_EQ(reducedBellMatrix.p->e[0].p->e[0].p, bellMatrix.p);
+//   EXPECT_TRUE(reducedBellMatrix.p->e[0].p->e[1].isZeroTerminal());
+//   EXPECT_TRUE(reducedBellMatrix.p->e[0].p->e[2].isZeroTerminal());
+//   EXPECT_TRUE(reducedBellMatrix.p->e[0].p->e[3].isZeroTerminal());
+// }


test/dd/test_package.cpp

+// TEST(DDPackageTest, Identity) {
+//   auto dd = std::make_unique<dd::Package<>>(4);
+//
+//   EXPECT_TRUE(dd->makeIdent(0).isOneTerminal());
+//   EXPECT_TRUE(dd->makeIdent(0, -1).isOneTerminal());
+//
+//   auto id3 = dd->makeIdent(3);
+//   EXPECT_EQ(dd->makeIdent(0, 2), id3);
+//   const auto& table = dd->getIdentityTable();
+//   EXPECT_NE(table[2].p, nullptr);
+//
+//   auto id2 = dd->makeIdent(0, 1); // should be found in idTable
+//   EXPECT_EQ(dd->makeIdent(2), id2);
+//
+//   auto id4 = dd->makeIdent(0, 3); // should use id3 and extend it
+//   EXPECT_EQ(dd->makeIdent(0, 3), id4);
+//   EXPECT_NE(table[3].p, nullptr);
+//
+//   auto idCached = dd->makeIdent(4);
+//   EXPECT_EQ(id4, idCached);
+// }


test/dd/test_package.cpp

+// TEST(DDPackageTest, Extend) {
+//   auto dd = std::make_unique<dd::Package<>>(4);
+//
+//   auto id = dd->makeIdent(3);
+//   EXPECT_EQ(id.p->v, 2);
+//   EXPECT_EQ(id.p->e[0], id.p->e[3]);
+//   EXPECT_EQ(id.p->e[1], id.p->e[2]);
+//   EXPECT_TRUE(id.p->isIdentity());
+//
+//   auto ext = dd->extend(id, 0, 1);
+//   EXPECT_EQ(ext.p->v, 3);
+//   EXPECT_EQ(ext.p->e[0], ext.p->e[3]);
+//   EXPECT_EQ(ext.p->e[1], ext.p->e[2]);
+//   EXPECT_TRUE(ext.p->isIdentity());
+// }


test/dd/test_package.cpp

+  //auto goalRow0 =
+  //    dd::CVec{{1., 0.}, {0., 0.}};
+  //auto goalRow1 =
+  //    dd::CVec{{0., 0.}, {1., 0.}};
+  //auto goalMatrix = dd::CMat{{1, 0}, {0, 1}};//dd::CMat{goalRow0, goalRow1};
+  //ASSERT_EQ(dd->getMatrix(cxGate), goalMatrix);


test/dd/test_package.cpp

+      dd::CVec{{0., 0.}, {0., 0.}, {1., 0.}, {0., 0.}};
+  auto goalRow3 =
+      dd::CVec{{0., 0.}, {0., 0.}, {0., 0.}, {1., 0.}};
+  auto goalMatrix = dd::CMat{goalRow0, goalRow1, goalRow2, goalRow3};//dd::CMat{goalRow0, goalRow1};


include/dd/Package.hpp

+      // process lines below target
+      auto z = static_cast<Qubit>(start);
+      std::array<mEdge, NEDGE> local{};
+      for (; z < target; z++) {


include/dd/Package.hpp

+  // ComplexValue getValueByPath(const mEdge& e, const Complex& amp, std::size_t
+  // i,
+  //                             std::size_t j, int level) {
+  //   auto c = cn.mulCached(e.w, amp);
+  //
+  //  if (e.isTerminal()) {
+  //    cn.returnToCache(c);
+  //    return {CTEntry::val(c.r), CTEntry::val(c.i)};
+  //  }
+  //
+  //  const bool row = (i & (1ULL << level)) != 0U;
+  //  const bool col = (j & (1ULL << level)) != 0U;
+  //
+  //  ComplexValue r{};
+  //  if (!row && !col && !e.p->e[0].w.approximatelyZero()) {
+  //    r = getValueByPath(e.p->e[0], c, i, j, level-1);
+  //  } else if (!row && col && !e.p->e[1].w.approximatelyZero()) {
+  //    r = getValueByPath(e.p->e[1], c, i, j, level-1);
+  //  } else if (row && !col && !e.p->e[2].w.approximatelyZero()) {
+  //    r = getValueByPath(e.p->e[2], c, i, j, level-1);
+  //  } else if (row && col && !e.p->e[3].w.approximatelyZero()) {
+  //    r = getValueByPath(e.p->e[3], c, i, j, level-1);
+  //  }
+  //  cn.returnToCache(c);
+  //  return r;
+  //}


include/dd/Package.hpp

+  // ComplexValue getValueByPath(const vEdge& e, const Complex& amp,
+  //                             std::size_t i) {
+  //   auto c = cn.mulCached(e.w, amp);
+  //
+  //  if (e.isTerminal()) {
+  //    cn.returnToCache(c);
+  //    return {CTEntry::val(c.r), CTEntry::val(c.i)};
+  //  }
+  //
+  //  const bool one = (i & (1ULL << e.p->v)) != 0U;
+  //
+  //  ComplexValue r{};
+  //  if (!one && !e.p->e[0].w.approximatelyZero()) {
+  //    r = getValueByPath(e.p->e[0], c, i);
+  //  } else if (one && !e.p->e[1].w.approximatelyZero()) {
+  //    r = getValueByPath(e.p->e[1], c, i);
+  //  }
+  //  cn.returnToCache(c);
+  //  return r;
+  //}


test/dd/test_package.cpp

+  // auto goalRow0 =
+  //     dd::CVec{{1., 0.}, {0., 0.}};
+  // auto goalRow1 =
+  //     dd::CVec{{0., 0.}, {1., 0.}};
+  // auto goalMatrix = dd::CMat{{1, 0}, {0, 1}};//dd::CMat{goalRow0, goalRow1};
+  // ASSERT_EQ(dd->getMatrix(cxGate), goalMatrix);


test/dd/test_package.cpp

+  auto goalRow2 = dd::CVec{{0., 0.}, {0., 0.}, {1., 0.}, {0., 0.}};
+  auto goalRow3 = dd::CVec{{0., 0.}, {0., 0.}, {0., 0.}, {1., 0.}};
+  auto goalMatrix = dd::CMat{goalRow0, goalRow1, goalRow2,
+                             goalRow3}; // dd::CMat{goalRow0, goalRow1};


test/dd/test_package.cpp

+// TEST(DDPackageTest, ToffoliTable) {
+//   auto dd = std::make_unique<dd::Package<>>(4);
+//
+//   // try to search for a toffoli in an empty table
+//   auto toffoli = dd->toffoliTable.lookup(3, {0_nc, 1_pc}, 2);
+//   EXPECT_EQ(toffoli.p, nullptr);
+//   if (toffoli.p == nullptr) {
+//     toffoli = dd->makeGateDD(dd::Xmat, 3, {0_nc, 1_pc}, 2);
+//     dd->toffoliTable.insert(3, {0_nc, 1_pc}, 2, toffoli);
+//   }
+//
+//   // try again with same toffoli
+//   auto toffoliTableEntry = dd->toffoliTable.lookup(3, {0_nc, 1_pc}, 2);
+//   EXPECT_NE(toffoliTableEntry.p, nullptr);
+//   EXPECT_EQ(toffoli, toffoliTableEntry);
+//
+//   // try again with different controlled toffoli
+//   toffoliTableEntry = dd->toffoliTable.lookup(3, {0_pc, 1_pc}, 2);
+//   EXPECT_EQ(toffoliTableEntry.p, nullptr);
+//
+//   // try again with different qubit toffoli
+//   toffoliTableEntry = dd->toffoliTable.lookup(4, {0_pc, 1_pc, 2_pc}, 3);
+//   EXPECT_EQ(toffoliTableEntry.p, nullptr);
+//
+//   // clear the table
+//   dd->toffoliTable.clear();
+//   toffoliTableEntry = dd->toffoliTable.lookup(3, {0_nc, 1_pc}, 2);
+//   EXPECT_EQ(toffoliTableEntry.p, nullptr);
+// }


include/dd/Package.hpp

@@ -544,7 +563,9 @@

    [[maybe_unused]] const auto before = cn.cacheCount();

-    const auto level = static_cast<Qubit>(std::log2(length) - 1);
+    if (level == -1) {


include/dd/Package.hpp

+        getMatrix(e.p->e[0], c, i, j, mat, level - 1);
+      }
+      if (!e.p->e[1].w.approximatelyZero()) {
+        getMatrix(e.p->e[1], c, i, y, mat, level - 1);


include/dd/Package.hpp

+        getMatrix(e.p->e[1], c, i, y, mat, level - 1);
+      }
+      if (!e.p->e[2].w.approximatelyZero()) {
+        getMatrix(e.p->e[2], c, x, j, mat, level - 1);


include/dd/Package.hpp

+        getMatrix(e.p->e[2], c, x, j, mat, level - 1);
+      }
+      if (!e.p->e[3].w.approximatelyZero()) {
+        getMatrix(e.p->e[3], c, x, y, mat, level - 1);


include/dd/Package.hpp

+        getMatrix(e.p->e[2], c, x, j, mat, level - 1);
+      }
+      if (!e.p->e[3].w.approximatelyZero()) {
+        getMatrix(e.p->e[3], c, x, y, mat, level - 1);


include/dd/Package.hpp

+    } else if ((!e.isTerminal() && e.p->v < level) ||
+               (e.isTerminal() && level != -1)) {
+      getMatrix(e, c, i, j, mat, level - 1);
+      getMatrix(e, c, x, y, mat, level - 1);


include/dd/Package.hpp

+    } else if ((!e.isTerminal() && e.p->v < level) ||
+               (e.isTerminal() && level != -1)) {
+      getMatrix(e, c, i, j, mat, level - 1);
+      getMatrix(e, c, x, y, mat, level - 1);


include/dd/Simulation.hpp

@@ -26,7 +26,7 @@

  // correct permutation if necessary
  changePermutation(e, permutation, qc->outputPermutation, dd);
-  e = dd->reduceGarbage(e, qc->garbage);
+  // e = dd->reduceGarbage(e, qc->garbage);


src/dd/Simulation.cpp

@@ -83,7 +83,7 @@

    // correct permutation if necessary
    changePermutation(e, permutation, qc->outputPermutation, dd);
-    e = dd->reduceGarbage(e, qc->garbage);
+    // e = dd->reduceGarbage(e, qc->garbage);


Signed-off-by: burgholzer <[email protected]>

BertiFlorea · 2024-01-30T20:38:33Z

Hey 👋🏼
After long battles with Git, I finally managed to resolve as much as possible of the conflicts. However, @burgholzer you could take a closer look at some of the following functions in the DD package header:

checkSpecialMatrices (The symmetry check was removed in ⚡ Skip symmetry computation and 🔥 remove transpose method #442, however, if we remove the symmetry check and the identity check, then we would only have to check if it is a terminal the parameter node)
add2 (Here I tried to keep the logic from the current branch)
reduceAncillaeRecursion (I kept the version from the identity-removal branch)
Lines from 2226 - 2538 (Most of the methods between these lines do not exist anymore in the current version of mqt-core, so I didn't know if they should be kept or not)

Additionally, in Edge.cpp the isIdentity method is commented out because I tried to implement it in the header file (Edge.hpp). Still, I wasn't sure what to return for the else case (therefore I left it commented where it initially was, in Edge.cpp).

There are still many issues and changes that need to be addressed, but for the moment if you could take a look and review the current status would be great! (I am sure there are flagrant mistakes or some urgent changes that need to be done in order to also fix the CI) Any hint or advice no matter how small is very welcome! 🙂

Lastly, apart from bringing the branch up to date, as discussed, there are some methods in the package that do not yet account for the missing identity nodes. Would it be possible to highlight them in your review to make it easier to track? 🙏🏼

P.S. Many thanks in advance for your time to review, because I know there are quite a lot of places to investigate. (I think around 211 commits have been merged)

burgholzer

Hey @BertiFlorea 👋🏼

Many thanks for taking on this task and resolving all those conflicts with main. That must have been quite burdensome.
Nevertheless, I think the merge went rather well. I added comments to some leftover places, where something is not quite right yet. But these should be easy to fix.

Naturally, the most important thing right now is getting the code to compile again.
After that, some of the methods will need adjustments to account for the new identity-less structure.
The good thing here is that the gate construction, the addition, and the multiplication all seem to be in a good state already and look really clean now. This means that the main functionality should be working well already.
All it takes now is to "just" (that's a big "just") adapt the utility functions for translating DDs to vectors and matrices as well as some smaller mathematical functions such as the kronecker product and ancillary/garbage reduction.
As you requested, I explicitly tried to add comments to the respective places that should help keeping track of what still needs to change.

We can really take this step. So let's try to first resolve all the easy comments and suggestions.
Let me know if you have any questions.

include/mqt-core/dd/FunctionalityConstruction.hpp

include/mqt-core/dd/Node.hpp

include/mqt-core/dd/Package.hpp

Co-authored-by: Lukas Burgholzer <[email protected]>

codecov · 2024-03-19T15:44:47Z

Codecov Report

Attention: Patch coverage is 96.01227% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 91.2%. Comparing base (45e6cd5) to head (8093e2a).

Additional details and impacted files

@@          Coverage Diff          @@
##            main    #358   +/-   ##
=====================================
  Coverage   91.1%   91.2%           
=====================================
  Files        132     132           
  Lines      13918   13998   +80     
  Branches    2197    2230   +33     
=====================================
+ Hits       12693   12775   +82     
+ Misses      1225    1223    -2

Flag	Coverage Δ
cpp	`90.9% <96.0%> (+<0.1%)`	⬆️
python	`99.5% <ø> (ø)`

Files	Coverage Δ
include/mqt-core/dd/Node.hpp	`100.0% <ø> (ø)`
include/mqt-core/dd/NoiseFunctionality.hpp	`100.0% <ø> (ø)`
include/mqt-core/dd/Operations.hpp	`88.5% <100.0%> (-0.5%)`	⬇️
src/dd/Edge.cpp	`97.2% <100.0%> (-1.0%)`	⬇️
src/dd/FunctionalityConstruction.cpp	`96.8% <100.0%> (ø)`
src/dd/NoiseFunctionality.cpp	`97.1% <100.0%> (+<0.1%)`	⬆️
src/dd/Operations.cpp	`98.7% <100.0%> (ø)`
include/mqt-core/dd/CachedEdge.hpp	`84.2% <66.6%> (-1.6%)`	⬇️
include/mqt-core/dd/ComplexValue.hpp	`87.5% <0.0%> (-12.5%)`	⬇️
include/mqt-core/dd/Edge.hpp	`94.1% <83.3%> (-2.6%)`	⬇️
... and 1 more

... and 4 files with indirect coverage changes

Signed-off-by: burgholzer <[email protected]>

# Conflicts: # test/dd/test_package.cpp

## Description This PR fixes #567 and should subsequently allow to fix cda-tum/mqt-ddsim#361, which is the final blocker for merging #358. ## Checklist:  - [x] The pull request only contains commits that are related to it. - [x] I have added appropriate tests and documentation. - [x] I have made sure that all CI jobs on GitHub pass. - [x] The pull request introduces no new warnings and follows the project's style guidelines. --------- Signed-off-by: burgholzer <[email protected]>

Signed-off-by: burgholzer <[email protected]>

burgholzer

All the checks are green, all the dependent PRs are green as well.
So this epic can finally be merged 🎉
Thanks to everyone that contributed!

## Description This PR pulls in the changes from cda-tum/mqt-core#358, which considerably changes the way matrix decision diagrams are represented. Particularly, any node resembling the identity is now eliminated and only implicitly represented. This further compacts the representation of quantum gates and makes the identity the most compact it can be---a single terminal node. The overall performance improvements are still to be evaluated. ## Checklist:  - [x] The pull request only contains commits that are related to it. - [x] I have added appropriate tests and documentation. - [x] I have made sure that all CI jobs on GitHub pass. - [x] The pull request introduces no new warnings and follows the project's style guidelines. --------- Signed-off-by: burgholzer <[email protected]>

## Description This is the first of probably many follow-up PRs to #358, which tries to simplify the underlying functions and methods for representing operations. This PR specifically streamlines the `makeGateDD` method in the DD package and eliminates the `nqubits` and `start` parameters, which are no longer necessary. ## Checklist:  - [x] The pull request only contains commits that are related to it. - [x] I have added appropriate tests and documentation. - [x] I have made sure that all CI jobs on GitHub pass. - [x] The pull request introduces no new warnings and follows the project's style guidelines. Signed-off-by: burgholzer <[email protected]>

## Description The second follow-up PRs to #358, which tries to simplify the underlying functions and methods for representing operations. This PR specifically streamlines the `makeTwoQubitGateDD` method in the DD package and eliminates the `nqubits` and `start` parameters, which are no longer necessary. ## Checklist:  - [x] The pull request only contains commits that are related to it. - [x] I have added appropriate tests and documentation. - [x] I have made sure that all CI jobs on GitHub pass. - [x] The pull request introduces no new warnings and follows the project's style guidelines. --------- Signed-off-by: burgholzer <[email protected]>

…rarchy (#574) ## Description The third follow-up PRs to #358, which tries to simplify the `Operation` class hierarchy by eliminating the `nqubits` and `startingQubit` members, which were purely in place for managing the corresponding decision diagrams. This also practically fixes #345. Only state creation routines now have the additional starting qubit parameter. ## Checklist:  - [x] The pull request only contains commits that are related to it. - [x] I have added appropriate tests and documentation. - [x] I have made sure that all CI jobs on GitHub pass. - [x] The pull request introduces no new warnings and follows the project's style guidelines. --------- Signed-off-by: burgholzer <[email protected]>

## Description This PR pulls in the changes from cda-tum/mqt-core#358, which considerably changes the way matrix decision diagrams are represented. Particularly, any node resembling the identity is now eliminated and only implicitly represented. This further compacts the representation of quantum gates and makes the identity the most compact it can be---a single terminal node. The overall performance improvements are still to be evaluated. Surprisingly few changes were needed to make this work in QCEC. ## Checklist:  - [x] The pull request only contains commits that are related to it. - [x] I have added appropriate tests and documentation. - [x] I have made sure that all CI jobs on GitHub pass. - [x] The pull request introduces no new warnings and follows the project's style guidelines. --------- Signed-off-by: burgholzer <[email protected]>

github-advanced-security bot found potential problems Jun 26, 2023

View reviewed changes

aaronleesander requested a review from burgholzer June 28, 2023 14:09

github-advanced-security bot found potential problems Jun 28, 2023

View reviewed changes

burgholzer added feature New feature or request minor Minor version update DD Anything related to the DD package c++ Anything related to C++ code labels Jul 7, 2023

burgholzer added this to the DD Package Improvements milestone Jul 7, 2023

github-advanced-security bot found potential problems Aug 7, 2023

View reviewed changes

burgholzer removed their request for review August 16, 2023 16:48

github-advanced-security bot found potential problems Aug 27, 2023

View reviewed changes

include/dd/Package.hpp Fixed Show fixed Hide fixed

include/dd/Package.hpp Fixed Show fixed Hide fixed

github-advanced-security bot found potential problems Aug 27, 2023

View reviewed changes

github-advanced-security bot found potential problems Aug 31, 2023

View reviewed changes

burgholzer changed the title ~~WIP: Removal of identity nodes in matrix DDs~~ ✨ Removal of identity nodes in matrix DDs Sep 14, 2023

burgholzer mentioned this pull request Sep 14, 2023

🐛 Fix identity handling in DD multiplication #426

Merged

4 tasks

✨ strip matrix DDs of their identity

d5993fc

Signed-off-by: burgholzer <[email protected]>

burgholzer force-pushed the identity-removal branch from 59866e2 to d5993fc Compare September 14, 2023 05:59

BertiFlorea and others added 2 commits January 30, 2024 21:01

Merge branch 'main' into identity-removal

84f8571

🎨 pre-commit fixes

665c984

BertiFlorea requested a review from burgholzer January 30, 2024 20:50

burgholzer requested changes Jan 31, 2024

View reviewed changes

BertiFlorea and others added 8 commits January 31, 2024 19:43

🔥 Remove old buildFunctionality function

2e1e3c1

Co-authored-by: Lukas Burgholzer <[email protected]>

♻️ Update data layout comment in include/mqt-core/dd/Node.hpp

6829b5c

Co-authored-by: Lukas Burgholzer <[email protected]>

🔥 remove isSymmetric function

9e3a1b0

Co-authored-by: Lukas Burgholzer <[email protected]>

🔥 remove isSymmetric function

38ecda9

Co-authored-by: Lukas Burgholzer <[email protected]>

🔥 ♻️ integrate suggestions from the review

93beb9c

🐛 fix makeDDNode function in DD package

4372681

🎨 pre-commit fixes

254e9a1

Merge branch 'main' into identity-removal

eaaacfb

Merge branch 'refs/heads/main' into identity-removal

1cfc12e

burgholzer added 8 commits March 19, 2024 16:46

🩹 enable identity reduction for density matrices

4443744

Signed-off-by: burgholzer <[email protected]>

🐛 fix kronecker product computation

c1df60e

Signed-off-by: burgholzer <[email protected]>

🐛 fix trace computation

033d0dd

Signed-off-by: burgholzer <[email protected]>

🩹 adjust the isCloseToIdentity check

38b4766

Signed-off-by: burgholzer <[email protected]>

🚨 small clang-tidy recommendation

37c2474

Signed-off-by: burgholzer <[email protected]>

♻️🐛 fix and refactor ancillary and garbage reduction

44c634a

Signed-off-by: burgholzer <[email protected]>

🩹 properly track reference count in reduction methods

2404382

Signed-off-by: burgholzer <[email protected]>

♻️ adjust changePermutation method for identity-less structure

35a438b

Signed-off-by: burgholzer <[email protected]>

This was referenced Mar 20, 2024

✨ Stripping DDs of their identity cda-tum/mqt-qcec#377

Merged

✨ Stripping DDs of their identity cda-tum/mqt-ddsim#361

Merged

🐛 Density matrix DDs do not properly handle identity nodes #567

Closed

🐛 Density matrix idenity handling #569

Merged

Merge branch 'refs/heads/main' into identity-removal

564a037

# Conflicts: # test/dd/test_package.cpp

burgholzer added 3 commits March 24, 2024 14:01

🔀 merge main

d45b6b1

Signed-off-by: burgholzer <[email protected]>

🩹 adapt to latest changes from main

d813dfa

Signed-off-by: burgholzer <[email protected]>

🩹 handle identities in noise application

8093e2a

Signed-off-by: burgholzer <[email protected]>

burgholzer approved these changes Mar 24, 2024

View reviewed changes

burgholzer merged commit af3eb94 into main Mar 24, 2024
37 checks passed

burgholzer deleted the identity-removal branch March 24, 2024 22:49

This was referenced Mar 25, 2024

♻️ streamline makeGateDD method #571

Merged

♻️ streamline makeTwoQubitGateDD method #572

Merged

burgholzer mentioned this pull request Mar 26, 2024

♻️ Eliminate nqubits and startingQubit from Operation class hierarchy #574

Merged

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

✨ Removal of identity nodes in matrix DDs #358

✨ Removal of identity nodes in matrix DDs #358

aaronleesander commented Jun 20, 2023 •

edited by burgholzer

Loading

BertiFlorea commented Jan 30, 2024 •

edited

Loading

burgholzer left a comment

codecov bot commented Mar 19, 2024 •

edited

Loading

burgholzer left a comment

✨ Removal of identity nodes in matrix DDs #358

✨ Removal of identity nodes in matrix DDs #358

Conversation

aaronleesander commented Jun 20, 2023 • edited by burgholzer Loading

BertiFlorea commented Jan 30, 2024 • edited Loading

burgholzer left a comment

Choose a reason for hiding this comment

codecov bot commented Mar 19, 2024 • edited Loading

Codecov Report

burgholzer left a comment

Choose a reason for hiding this comment

aaronleesander commented Jun 20, 2023 •

edited by burgholzer

Loading

BertiFlorea commented Jan 30, 2024 •

edited

Loading

codecov bot commented Mar 19, 2024 •

edited

Loading