🏗️ Switch the pyfiction build system from raw setuptools to scikit-build-core
#592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcelwa
added
python
|
clang-tidy review says "All clean, LGTM! 👍" |
marcelwa
changed the title
pyfiction build system from setuptools to scikit-buildpyfiction build system from raw setuptools to scikit-build
|
clang-tidy review says "All clean, LGTM! 👍" |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #592 +/- ##
=======================================
Coverage 98.12% 98.12%
=======================================
Files 232 232
Lines 35410 35410
Branches 1692 1691 -1
=======================================
+ Hits 34746 34747 +1
+ Misses 662 661 -1
Partials 2 2
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
marcelwa
changed the title
pyfiction build system from raw setuptools to scikit-buildpyfiction build system from raw setuptools to scikit-build-core
…N_TEST`, which is already set to `OFF`
Signed-off-by: GitHub Actions <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+90
to
+117
| # def docs(session: nox.Session) -> None: | ||
| # """Build the docs. Use "--non-interactive" to avoid serving. Pass "-b linkcheck" to check links.""" | ||
| # parser = argparse.ArgumentParser() | ||
| # parser.add_argument("-b", dest="builder", default="html", help="Build target (default: html)") | ||
| # args, posargs = parser.parse_known_args(session.posargs) | ||
| # | ||
| # serve = args.builder == "html" and session.interactive | ||
| # extra_installs = ["sphinx-autobuild"] if serve else [] | ||
| # session.install(*BUILD_REQUIREMENTS, *extra_installs) | ||
| # session.install("--no-build-isolation", "-ve.[docs]") | ||
| # | ||
| # if args.builder == "linkcheck": | ||
| # session.run("sphinx-build", "-b", "linkcheck", "docs", "docs/_build/linkcheck", *posargs) | ||
| # return | ||
| # | ||
| # shared_args = ( | ||
| # "-n", # nitpicky mode | ||
| # "-T", # full tracebacks | ||
| # f"-b={args.builder}", | ||
| # "docs", | ||
| # f"docs/_build/{args.builder}", | ||
| # *posargs, | ||
| # ) | ||
| # | ||
| # if serve: | ||
| # session.run("sphinx-autobuild", *shared_args) | ||
| # else: | ||
| # session.run("sphinx-build", "--keep-going", *shared_args) |
Check notice
Code scanning / CodeQL
Commented-out code Note
Signed-off-by: GitHub Actions <[email protected]>
Signed-off-by: GitHub Actions <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes big changes to the build system and overall tooling of pyfiction.
scikit-build-corefrom rawsetuptools.uvfor dependency management and builds.noxfor testing.Checklist: