Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ QuickTrace: An Efficient Contour Tracing Algorithm for Defect Robustness Simulation #546

Open
wants to merge 266 commits into
base: main
Choose a base branch
from

Conversation

Drewniok
Copy link
Collaborator

Description

This PR implements three key methods—Grid Search, Random Sampling, and Contour Tracing—to identify and analyze the atomic defect operational domain.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have added a changelog entry.
  • I have created/adjusted the Python bindings for any new or updated functionality.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

Drewniok and others added 30 commits February 6, 2024 07:47
# Conflicts:
#	include/fiction/algorithms/physical_design/design_sidb_gates.hpp
# Conflicts:
#	cli/cmd/simulation/opdom.hpp
#	docs/algorithms/sidb_simulation.rst
#	include/fiction/algorithms/physical_design/design_sidb_gates.hpp
#	include/fiction/algorithms/simulation/sidb/assess_physical_population_stability.hpp
#	include/fiction/algorithms/simulation/sidb/critical_temperature.hpp
#	include/fiction/algorithms/simulation/sidb/is_operational.hpp
#	include/fiction/algorithms/simulation/sidb/maximum_defect_influence_position_and_distance.hpp
#	include/fiction/algorithms/simulation/sidb/operational_domain.hpp
#	include/fiction/types.hpp
#	test/algorithms/simulation/sidb/assess_physical_population_stability.cpp
#	test/algorithms/simulation/sidb/is_operational.cpp
#	test/algorithms/simulation/sidb/maximum_defect_influence_position_and_distance.cpp
#	test/algorithms/simulation/sidb/operational_domain.cpp
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

include/fiction/layouts/cartesian_layout.hpp Show resolved Hide resolved
include/fiction/layouts/cartesian_layout.hpp Show resolved Hide resolved
Drewniok and others added 13 commits November 21, 2024 14:04
# Conflicts:
#	bindings/mnt/pyfiction/include/pyfiction/algorithms/simulation/sidb/assess_physical_population_stability.hpp
#	bindings/mnt/pyfiction/include/pyfiction/algorithms/simulation/sidb/defect_operational_domain.hpp
#	bindings/mnt/pyfiction/include/pyfiction/algorithms/simulation/sidb/determine_physically_valid_parameters.hpp
#	bindings/mnt/pyfiction/include/pyfiction/algorithms/simulation/sidb/maximum_defect_influence_position_and_distance.hpp
#	bindings/mnt/pyfiction/include/pyfiction/algorithms/simulation/sidb/occupation_probability_of_excited_states.hpp
#	bindings/mnt/pyfiction/include/pyfiction/inout/read_sqd_layout.hpp
#	bindings/mnt/pyfiction/include/pyfiction/inout/write_defect_operational_domain.hpp
#	bindings/mnt/pyfiction/include/pyfiction/layouts/cartesian_layout.hpp
#	bindings/mnt/pyfiction/include/pyfiction/layouts/cell_level_layout.hpp
#	bindings/mnt/pyfiction/include/pyfiction/technology/sidb_lattice.hpp
#	bindings/mnt/pyfiction/test/algorithms/simulation/sidb/test_assess_physical_population_stability.py
#	bindings/mnt/pyfiction/test/algorithms/simulation/sidb/test_defect_operational_domain.py
#	include/fiction/io/write_svg_layout.hpp
#	test/utils/blueprints/layout_blueprints.hpp
…thm' into defect_operational_domain_algorithm

# Conflicts:
#	bindings/mnt/pyfiction/include/pyfiction/algorithms/simulation/sidb/determine_physically_valid_parameters.hpp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants