Add RPA Support #234
Merged
Add RPA Support #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
May be useful later for the Controller.
It's now in Storage::addRpaDataForHeight_nolock, since it does some defensive sanity checking.
It needs work in recovering from DL failure and other corner cases but it basically works.
I'm pretty sure we are solid now and the RPA index eventally synchs separate of the general block download on config change. Meaning users get a decent experience with the index if they play with enabled/disabled toggling.
This is due to the addition of the RPA index facility. Also bumped protocol version to 1.5.3 due to addition of new RPA RPCs.
It really should be a percentage of the current download progress and not a full blockchain percentage as the normal blocks synch is. Fixed.
This is because on some platforms they are actually #defines to some global thing, so eg `bitcoin::htole16` was failing to compile on such platforms.
GCC-11 + Qt5 didn't like some of the stuff we did in recent commits. Fixed.
They are unimplemented anyway and no clients use them (for now).
And also some other minor tweaks. Mostly a renaming/nit commit.
This is more akin to how existing calls operate. Also updated the electrum-cash-protocol submodule pointer to latest.
tomFlowee
reviewed
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on work by Jt Freeman from here: https://github.com/Electron-Cash/Fulcrum-RPA
Thanks to Jonald Fyookball for getting the ball rolling and merging the above RPA implementation to the latest Fulcrum here: https://github.com/fyookball/Fulcrum
This is a complete reimplementation of the above, however, since the above suffered from some performance issues, had no ability to turn the index on or off, and had no way for extant Fulcrum servers to just turn the index "on" after an upgrade: auto-synch of just the index was needed, basically!
What's more, the original Fulcrum-RPA test implementation had some bugs (it incorrectly refused to index some inputs, and did index others it shouldn't have).
This work was paid for by the community via the flipstarter campaign at: https://flipstarter.c3-soft.com/
Thank you to all who donated to make this work possible!