Implement correct address indexing for outputs containing CashTokens (BCH) + Code cleanup #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- token stuff - updated serialize.h - misc other updates
- ScriptHashID (replaces CScriptID) for p2sh32 support - Added cashaddr p2sh32 support.
- Added "streams" unit test from BCHN - Imported more useful code from BCHN - Updated bitcoin/test.cpp
Incorporated into the "streams" test for Fulcrum
Just paranoia to catch regressions where this flag stops working.
This is to differentiate this from the non-cashtokens master. Also when we merge this branch into master we will use this version for the upcoming release.
This is to catch regressions, since the coin should never be "Unknown" (it defaults to BCH anyway if we cannot parse daemon version string).
Also added a test to check this if it ever regresses.
Just for belt-and-suspenders.
- Removal of dead/unused code - Removed the never-used BTC_unused.* - Changed all include guards to #pragma once - Removal of unused feerate.*
Use lex compare rather than memcmp for the _hash, since it's more readable.
Specifically for some of their c'tors. This helps with STL containers.
cculianu
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
scriptPubKeyappears. See: https://github.com/bitjson/cashtokens