Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove invalid keys #2

Merged
merged 1 commit into from
Feb 6, 2018
Merged

Remove invalid keys #2

merged 1 commit into from
Feb 6, 2018

Conversation

pchaigno
Copy link
Contributor

Are the highlightPairs and smartTypingPairs keys serving any purpose? They are detected as invalid on GitHub.com and throwing errors (see github-linguist/linguist#3924 for further details).

@pchaigno
Copy link
Contributor Author

pchaigno commented Jan 6, 2018

@ccreutzig Did you get a chance to look into this?

@ccreutzig ccreutzig merged commit ffa7380 into ccreutzig:master Feb 6, 2018
@ccreutzig
Copy link
Owner

ccreutzig commented Feb 6, 2018

Sorry, forgot. Those were probably leftovers from porting the code from TextMate.

Thanks for the patch!

@pchaigno pchaigno deleted the remove-invalid-keys branch February 6, 2018 21:32
@pchaigno
Copy link
Contributor Author

pchaigno commented Feb 6, 2018

No problem. Thanks for merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants