Introduce new optional file_dom_el param

For passing in the file input directly, rather than with a selector.
ccnmtl · Sep 21, 2023 · c38ef59 · c38ef59
1 parent f6c36f6
commit c38ef59
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 1 deletion.
diff --git a/CHANGES b/CHANGES
@@ -2,6 +2,10 @@
 ==================
 * Adjust S3Upload.file_dom_selector to allow for any DOM selector
   rather than just an ID.
+* Introduced new optional param `file_dom_el` for passing in the file
+  input element directly. This is convenient when initializing
+  S3Upload from an event, as you can just pass in the event.target
+  object.
 
 0.3.3 (2023-03-03)
 ==================

diff --git a/README.md b/README.md
@@ -111,6 +111,8 @@ And
 <script>
 function s3_upload() {
     var s3upload = new S3Upload({
+        file_dom_el: null, // Optional, and overrides file_dom_selector
+                           // when present.
         file_dom_selector: '#file',
         s3_sign_put_url: '/sign_s3/', // change this if you route differently
         s3_object_name: $('#file')[0].value,

diff --git a/s3sign/static/s3sign/js/s3upload.js b/s3sign/static/s3sign/js/s3upload.js