Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ycv 154 integrate docker container poc #652

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dannyhchan
Copy link

@dannyhchan dannyhchan commented Jun 16, 2023

This is an experimental feature using docker.

@nikolas
Copy link
Member

nikolas commented Jun 16, 2023

Looking good! I'll make this a draft PR so we don't accidentally merge it yet.

Seeing as this is just adding some new configs, it wouldn't necessarily break production to merge this as is. But we'll do some thorough testing and documentation here first.

@nikolas nikolas marked this pull request as draft June 16, 2023 19:08
@dannyhchan
Copy link
Author

Thanks Nik for moving it to a draft PR. I was actually using this as also testing the Jira and Github linking as well. So as you can see my branch name and commits started with the ticket prefix and number.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants