Updates to K7 nav drawer and EUI to 9.4.0 (elastic#32864)

* update for new eui nav drawer * remove extraAction on flyout * fix mobile menu toggle * add i18n for recently reviewed nav link * progress on updating tests * replace EuiListGroup with EuiNavDrawerGroup * Quick label fixes - Removing aria-label if the same as label since the `EuiNavDrawerGroup` takes care of that - Truncating any recent items to just 64 characters and applying the `title` attribute to display the whole label. * Adding a truncation buffer * fix navDrawerRef * Update to EUI 9.3.0 Also comments out some logos that don’t exist that were throwing console errors * remove unused import * typo fix * One DTS too many in test * …all the small things… * Upgrade plugin dependencies and fix nav drawer test * update for new eui nav drawer * remove extraAction on flyout * fix mobile menu toggle * add i18n for recently reviewed nav link * progress on updating tests * replace EuiListGroup with EuiNavDrawerGroup * Quick label fixes - Removing aria-label if the same as label since the `EuiNavDrawerGroup` takes care of that - Truncating any recent items to just 64 characters and applying the `title` attribute to display the whole label. * Adding a truncation buffer * fix navDrawerRef * Update to EUI 9.3.0 Also comments out some logos that don’t exist that were throwing console errors * remove unused import * typo fix * One DTS too many in test * …all the small things… * Upgrade plugin dependencies and fix nav drawer test * Add support for normal image paths Updated to EUI 9.4.0 * update testing appMenu.clickLink selector * leave appsMenu closed while reading and clicking links * use saveVisualizationExpectSuccess to ensure modal is closed before continuing # Conflicts: # yarn.lock
cchaos · Mar 14, 2019 · af71fd6 · af71fd6
1 parent 4321fa7
commit af71fd6
Show file tree

Hide file tree

Showing 14 changed files with 105 additions and 322 deletions.
diff --git a/package.json b/package.json
@@ -94,7 +94,7 @@
   },
   "dependencies": {
     "@elastic/datemath": "5.0.2",
-    "@elastic/eui": "9.2.1",
+    "@elastic/eui": "9.4.0",
     "@elastic/filesaver": "1.1.2",
     "@elastic/good": "8.1.1-kibana2",
     "@elastic/numeral": "2.3.2",

diff --git a/src/legacy/core_plugins/kibana/server/tutorials/apm/index.js b/src/legacy/core_plugins/kibana/server/tutorials/apm/index.js
@@ -82,7 +82,7 @@ It allows you to monitor the performance of thousands of applications in real ti
           '{config.docs.base_url}guide/en/apm/get-started/{config.docs.version}/index.html',
       },
     }),
-    euiIconType: 'apmApp',
+    euiIconType: 'logoAPM',
     artifacts: artifacts,
     onPrem: onPremInstructions(apmIndexPatternTitle),
     elasticCloud: createElasticCloudInstructions(config),

diff --git a/src/legacy/core_plugins/kibana/server/tutorials/nats_logs/index.js b/src/legacy/core_plugins/kibana/server/tutorials/nats_logs/index.js
@@ -43,7 +43,7 @@ export function natsLogsSpecProvider(server, context) {
         learnMoreLink: '{config.docs.beats.filebeat}/filebeat-module-nats.html',
       },
     }),
-    euiIconType: 'logoNats',
+    // euiIconType: 'logoNats',
     artifacts: {
       dashboards: [
         {

diff --git a/src/legacy/core_plugins/kibana/server/tutorials/nats_metrics/index.js b/src/legacy/core_plugins/kibana/server/tutorials/nats_metrics/index.js
@@ -39,7 +39,7 @@ export function natsMetricsSpecProvider(server, context) {
         learnMoreLink: '{config.docs.beats.metricbeat}/metricbeat-module-nats.html',
       },
     }),
-    euiIconType: 'logoNats',
+    // euiIconType: 'logoNats',
     artifacts: {
       dashboards: [
         {

diff --git a/src/legacy/ui/public/chrome/api/nav.d.ts b/src/legacy/ui/public/chrome/api/nav.d.ts
@@ -28,6 +28,7 @@ export interface NavLink {
   subUrlBase: string;
   id: string;
   euiIconType: IconType;
+  icon?: string;
   active: boolean;
   lastSubUrl?: string;
   hidden?: boolean;