Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TypeScript updates #50

Merged
merged 2 commits into from
Apr 26, 2021
Merged

TypeScript updates #50

merged 2 commits into from
Apr 26, 2021

Conversation

thompsongl
Copy link

  • useColorPickerState needed a clearer return type
  • SerializedStyles is what the css prop accepts

@thompsongl thompsongl mentioned this pull request Apr 26, 2021
Merged
cchaos
cchaos reviewed Apr 26, 2021
View reviewed changes
Copy link
Owner

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh and also Thank you! 😆

cchaos
cchaos approved these changes Apr 26, 2021
View reviewed changes
Copy link
Owner

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thank you! This is why I really want to convert our examples to use Typescript. We'll find the problems before the get to the consumer.

@cchaos cchaos merged commit 344350b into cchaos:feature/css-in-js_themes Apr 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cchaos cchaos cchaos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thompsongl @cchaos