Make EuiTableSortMobile render EuiTableSortMobileItems #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added date, boolean and number support to the Query language. With that, also added support for the following operations on field clauses: - greater than (`gt`) - greater than or equals (`gte`) - less than (`lt`) - less than or equals (`lte`) When it comes to date values, we try to cover a large range of user friendly formats, including terms such as: `today`, `yesterday`, `last week`, `next week`, `this week`, `this month` and `last/next month/year`. Date operation also respect the granularity of the date.. for example, `today` refers to the full day, therefore the value has a `DAY` granularity. Therefore, the expression `date:'today'` will match any value that falls in the full day. With this change, the search bar also supports a "schema" - this enables defining a more granular set of rules of how the query should be interpreted. For example, the schema may state that field `count` is of type 'number' - if the user tries to assign a string to this field, a parsing error will be triggered. Aside from the data types, the schema enables defining finer validation logic for the assigned field values. The `EuiInMemoryTable` was updated such that it is now possible to set `schema: true` on its search box. This will deduce a schema from the configured columns. (this can further be enhanced in the future, by supporting `searchable` and `validate` properties on the table columns).
…ery string (elastic#598) Example: ``` const query = Query.parse(`john group:(eng or "marketing org") -date:'2004-03' -is:active`); console.log(Query.toEsQueryString(query)); ``` the above logs: ``` +john +(group:eng OR group:"marketing org") -date:(>=2004-03 AND <2004-04) +active:false ```
* Font weight fix for k6
* Add EuiComboBox and EuiHighlight. * calculatePopoverPosition service now accepts a positions argument so you can specify which positions are acceptable * Added closeButtonProps prop to EuiBadge, hollow badge type, and support for arbitrary hex color * Added support for arbitrary hex color to EuiIcon
* fix for focus state of disabled buttons elastic#560 * allow select to pass any node as option, fixes elastic#346
* Apply more specificity to fix disabled states
…lastic#628) What this PR does: 1. Separates Sass functions into a new `/global_styling/functions/` folder so that they don't dirty up the rest of the files. These get imported along with `global_styling` genetically like our other mixins. 2. Adds new math and color functions: * A bunch of math functions for the single purpose of calculating luminosity is Sass * Using luminosity, we now have functions to `checkContrast`, `chooseLightOrDarkText` and `makeHighContrastColor`.
) * Fix bug where clicking a pill's close button would close the list, by refining the focus and blur logic. * Fix bug with positioning the list when there's no scrollbar, caused by the absolute position in the CSS. * Fix bug with logic managing the euiBody-hasPortalContent class. * Add support for validation to EuiComboBox.
…io inputs (elastic#613) * Allow accordions to change height while open * Permit value on radio inputs, and pass as the 2nd arg in callbacks * Stop accordion toggle layout being responsive
Adds EuiDatePicker component
…ad (elastic#665) * Show and hide table action column via CSS
- Uses `header` prop to add `data-header` to table cell and ouput content on small screens.
- `hideforMobile`: doesn’t display the cell at xSmall breakpoint - `isMobileHeader`: doesn’t display `data-header` attribute but enlarges the text and displays it full width
- add `isSelectable` to a row and it will absolutely position the check box on the far left
- `EuiTableSortMobile` for the whole context menu - `EuiTableSortMobileItem` for individual buttons - BUG: The items don’t update their render on click - TODO: Add text to the trigger button signifying which column is being sorted on
- page changed - num of pages changed (BUG: scrolls up then back down because the button keeps focus)
- Must add `hasActions` to the BasicTable or Row to properly position the action buttons. - Q: On mobile should the action buttons always be visible?
- Added the comp `EuiTableHeaderMobile` to encapsulate multiple small screen only table options (sort/select all, etc…) - Moved the other Mobile comps into the subfolder `/mobile`
- Added `isMobileFullWidth` as a prop to `EuiTableRowCell`
and increasing font size to normal
- Must add the prop `isExpandedRow` to the `EuiTableRow` to get the right calss.
- Truncation isn’t supported in mobile headers
- Must add prop `isExpander` to column/cell
- Bold and truncate table header - Increase width of select column - Rows select button is now xs instead of s (matches page numbers) - Aligning content also sets the text alignment - Fixed placement of loading indicator
- Added `isExpandable` prop to add a class to the parent row - Using `EuiButtonIcon` for collapsing button instead of `EuiLink`
…er can be closed. Fix centering of loading error message.
jen-huang
force-pushed
the
responsive-tables
branch
from
a7842f9 to
f005675
Compare
|
Hmm. I rebased my branch with upstream master. This appears to be no bueno since your branch isn't updated yet. Closing this PR, will make a new one shortly. |
cchaos
pushed a commit
that referenced
this pull request
Apr 18, 2018
…#670) * use react-virtualized to virtualize combo box options list * use smaller width and height * include group label in matching options list * add better text for example description * dynamically set width and height * Massage group title padding. Truncate text instead of wrapping it. Add title attribute to options for usability. (#1) * remove console.log and fix spelling * fix problems with settig focus on active option * more keyboard accessiblity work * Combo box focus state and text overflow (#2) * Call setState instead of setting activeOptionIndex directly. * Clear activeOptionIndex when you click the input. * Prevent a lot of input from overflowing the container. * Allow disabled options to be focused but not selected. * add throttle to incrementActiveOptionIndex to avoid keypresses getting UI out of sync * rowHeight prop * remove unneeded const * fix spacing in example text, fix lodash import * skip disabled options when using keyboard * Revert "skip disabled options when using keyboard" This reverts commit 47fa3ef.
cchaos
added a commit
that referenced
this pull request
Mar 17, 2020
* fixed errors * updated changelog * Update CHANGELOG.md * added preview in docs-section * Update CHANGELOG.md * added example file * Fixing anchor and disabled styles, updating example (#2) Thanks @cchaos * added tests * Update CHANGELOG.md Co-Authored-By: Caroline Horn <[email protected]> Co-authored-by: Caroline Horn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make EuiTableSortMobile render EuiTableSortMobileItems, so that popover can be closed. Popover not closing was making the custom table mobile sorting appear laggy.
Make loading & loading error message centered like on desktop view.