New development at openc2e/openc2e #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Python is installed or easy to install on every platform, and more people now are likely to know Python than to know Perl.
Needs to be in global namespace, as the functions are looked up via ADL
Better semantics than string slicing, and fixes the case where dirp ends in a trailing slash (legal, and happens when using ghc_filesystem).
std::filesystem (and polyfills) treat concatenating absolute paths differently than Boost.Filesystem: they ignore the left side of the operation. Since this is not what we want, ensure we only concatenate relative paths
…Clip Lets us remove boost::intrusive_ptr
Standalone it's useful for parsing and other tools (e.g. caos2pray)
Boost is _gone_ for the most common build type!
e.g. Sea Monkeys has: ARRAY "Navigable CA Indices" 0"
Fixes an issue introduced when copying image data into the bmpImage structure, where we were deleting the srcdata pointer after incrementing it.
The original Creatures engines use the CP-1252 encoding (you can see this in e.g. WhiteOnTransparentChars.s16, which maps over perfectly). Modern practices, however, are to store files and operate on strings in UTF-8. So, in this commit we do a couple things: 1) When parsing Pray or CAOS2Pray sources, convert them to UTF-8 if they're not already 2) When reading Pray files, convert strings to UTF-8, if they're not already 3) When writing Pray files, convert strings to CP-1252, if they're not already This follows the Robustness Principle of "be conservative in what you do, be liberal in what you accept."
Still needs to be hooked up in World, but the logic works
Ubuntu complains about std::domain_error and strlen, Windows complains about std::domain_error and ssize_t
It's much faster!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After chatting with fuzzie, bdonlan, nornagon, and diagonalfish, it seems there's no longer any way to access this repository.
I've created a new GitHub Organization and repository at openc2e/openc2e for new development.
At the time of writing, changes include:
If you're interested in contributing or running openc2e, please join me there!