Skip to content
This repository has been archived by the owner on Jan 13, 2022. It is now read-only.

Clean preexisting data using ImageStore #517

Merged
merged 17 commits into from
Oct 20, 2020

Conversation

mathemancer
Copy link
Contributor

Fixes

Fixes #356 by @mathemancer

Description

This PR adds two new DAGs:

  • One that systematically pulls all rows from the intermediary DB and runs them through the ImageStore (defined at src/cc_catalog_airflow/dags/cleaner_workflow.py), storing the resulting TSVs in a directory specific to cleaned, previously-ingested data, and
  • Another that loads TSVs from that directory back into the intermediary DB, with a slightly modified logic to overwrite the old data.

Technical details

The main file hooking things together is at src/cc_catalog_airflow/dags/util/pg_cleaner.py.

Tests

There are numerous new tests covering the functionality. Also, one is welcome to set up the dockerized dev environment using the README, load some data into the local DB using the appropriate workflows, then turn on the two new workflows:

  • postgres_image_cleaner
  • tsv_to_postgres_loader_overwrite
    to see their effects.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@mathemancer mathemancer requested review from zackkrida, aldenstpage, a team and ChariniNana and removed request for a team October 20, 2020 14:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

[Infrastructure] Maintain only pre-cleaned data in the upstream database
2 participants