Feedback #14
Open
Feedback #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cburgdorf
reviewed
Aug 29, 2020
cburgdorf
reviewed
Aug 29, 2020
g-r-a-n-t
commented
Sep 1, 2020
|
Alright, Ive coded up all of my suggestions, let me know if you disagree with anything :) |
cburgdorf
reviewed
Sep 10, 2020
| Ok(Prototype::Data(len)) => { | ||
| if strict { | ||
| let payload_info = rlp_val.payload_info().map_decoder_error()?; | ||
| let payload_info = rlp_val.payload_info().map_err(|err| err.to_py_err())?; |
There was a problem hiding this comment.
Mmh, the previous map_decoder_error() looks a bit cleaner to me...
|
Thanks for the continued feedback! I'm going to look through it more thoroughly soon when my brain gets out of Python land again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It will take a little more time for me to figure out what's going on here. For now I've just left a few inline comments and made some minor changes.
Looks good overall