Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duration fix #15

Merged
merged 7 commits into from
Dec 18, 2023
Merged

Duration fix #15

merged 7 commits into from
Dec 18, 2023

Conversation

bpogy
Copy link

@bpogy bpogy commented Dec 8, 2023

  • MT-2670 Fix for duration format error: "Duration must be in the format: P[nD][T[nH][nM][nS]]"

JackDunham
JackDunham reviewed Dec 18, 2023
View reviewed changes
mpd/duration.go Outdated
@@ -54,29 +54,16 @@ func (d *Duration) String() string {
if u < uint64(time.Second) {
Copy link

@JackDunham JackDunham Dec 18, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be LTE, rather than strictly LT, given that line 59 handles the strictly-equal case?

Copy link
Author

@bpogy bpogy Dec 18, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0 seconds ends-up to be < uint64(time.Second). There is unit test for that scenario, but I'll change it.

JackDunham
JackDunham reviewed Dec 18, 2023
View reviewed changes
go.mod
@@ -1,3 +1,3 @@
module github.com/zencoder/go-dash/v3

go 1.16
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe just leave at 1.16...or no greater than 1.18 (for bakery compatibility).

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

back to 1.16

JackDunham
JackDunham approved these changes Dec 18, 2023
View reviewed changes
Copy link

@JackDunham JackDunham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of comment/question, otherwise LGTM.

@bpogy bpogy merged commit 0701e40 into master Dec 18, 2023
1 check passed
@bpogy bpogy deleted the duration_fix branch December 18, 2023 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JackDunham JackDunham JackDunham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bpogy @JackDunham