autodetect installed macfuse version 4 in build.rs #104
Conversation
for install instructions.
build.rs
Outdated
| @@ -6,9 +8,14 @@ fn main() { | |||
| { | |||
| #[cfg(target_os = "macos")] | |||
| { | |||
| let probelib = if std::path::Path::new(MAC_FUSE_4).exists() { | |||
There was a problem hiding this comment.
Checking for the existence of this path seems brittle to me. Is it documented anywhere that it's guaranteed to exist for MacFuse 4.0? I think it would be better to detect this via pkg_config. In other words, first try to link against "fuse" and then fallback to "osxfuse", just like the non-macos code path below: https://github.com/cberner/fuser/pull/104/files#diff-d0d98998092552a1d3259338c2c71e118a5b8343dd4703c0c7f552ada7f9cb42L23
There was a problem hiding this comment.
my reasoning was that some package management tools might do some symlink shenanigans with the pkg_config files, so I decided to test for a file that only v4 installs. But you are totally right, simply trying to use it is a more stable approach - I implemented your suggested changes.
back to old osxfuse
I was redirected here in my issue report for zargony/fuse-rs#155 when building the crate against macFUSE 4.x. There were lots of renames going on, one of them being the pkg-config information. This PR autodetects an installed v4 and makes it build against v4 - the hello.rs example plus tests work fine for me (tested on macOS 11.1 with macFUSE 4.0.5 on a M1 MacBook Air).