forked from bisq-network/bisq
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
There are two structural / organizational reasons for this move: 1. References from one package to another should always be upward or lateral, never downward, as the latter causes package cycles (aka 'tangles') which damage the suppleness and understandability of a large codebase. Prior to this change the high-level bisq.core.CoreModule class imported many classes from child packages like bisq.core.{btc,dao,user,util}, etc. By moving CoreModule down into the '.app' package, it can reference all these other packages as siblings instead of doing so as a parent. 2. the bisq.core.desktop and bisq.core.app packages are the only locations that reference the CoreModule class. By moving the class into bisq.core.app, greater cohesion is acheived, again making the codebase that much easier to read and understand.
- Loading branch information
Showing
4 changed files
with
3 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters