Skip to content

Commit

Permalink
Doc updates from reading through them.
Browse files Browse the repository at this point in the history
Changes:
* clang is now used on Android
* Remove GYP mentions

Delete obsolete:
* common_build_tasks.md (all about GYP)
* shift_based_development.md (a git workflow, nothing chromium-specific)

Change-Id: I9ee75395bbe8f29ce4f856b14fbeff330d6b2c13
Reviewed-on: https://chromium-review.googlesource.com/679054
Reviewed-by: Eric Stevenson <[email protected]>
Commit-Queue: Andrew Grieve <[email protected]>
Cr-Commit-Position: refs/heads/master@{#503807}
  • Loading branch information
agrieve authored and Commit Bot committed Sep 22, 2017
1 parent 5bfab68 commit fe71bbc
Show file tree
Hide file tree
Showing 5 changed files with 7 additions and 369 deletions.
10 changes: 4 additions & 6 deletions docs/clang.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@
[Clang](http://clang.llvm.org/) is a compiler with many desirable features
(outlined on their website).

Chrome can be built with Clang. It is now the default compiler on Mac and Linux
for building Chrome, and it is currently useful for its warning and error
messages on Android and Windows.
Chrome can be built with Clang. It is now the default compiler on Android, Mac
and Linux for building Chrome, and it is currently useful for its warning and
error messages on Windows.

See
[the open bugs](http://code.google.com/p/chromium/issues/list?q=label:clang).
Expand Down Expand Up @@ -120,8 +120,6 @@ If your clang revision is very different from the one currently used in chromium

LLD is a relatively new linker from LLVM. The current focus is on Windows and
Linux support, where it can link Chrome approximately twice as fast as gold and
MSVC's link.exe as of this writing. LLD does not yet support generating PDB
files, which makes it hard to debug Chrome while using LLD.
MSVC's link.exe as of this writing.

on Windows.
Set `use_lld = true` in args.gn.
159 changes: 0 additions & 159 deletions docs/common_build_tasks.md

This file was deleted.

150 changes: 0 additions & 150 deletions docs/shift_based_development.md

This file was deleted.

4 changes: 0 additions & 4 deletions docs/use_find_bugs_for_android.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,6 @@ files. We have some scripts to run it over the Java code at build time.

## How To Run

For gyp builds, add `run_findbugs=1` to your `GYP_DEFINES`.

For gn builds, add `run_findbugs=true` to the args you pass to `gn gen`:

gn gen --args='target_os="android" run_findbugs=true'

Note that running findbugs will add time to your build. The amount of additional
Expand Down
Loading

0 comments on commit fe71bbc

Please sign in to comment.