Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return error when calling filter() with a wrong type in Gizmo #849

Merged
merged 1 commit into from
Oct 7, 2019
Merged

Return error when calling filter() with a wrong type in Gizmo #849

merged 1 commit into from
Oct 7, 2019

Conversation

dennwc
Copy link
Member

@dennwc dennwc commented Oct 7, 2019 •
edited
Loading

We were not checking the argument type for filter() correctly. This PR adds this check. But if we want to accept string values, we will need another change, similar to how has() is implemented.

Fixes #833

This change is Reviewable

@dennwc dennwc added this to the v0.7.6 milestone Oct 7, 2019
@dennwc dennwc self-assigned this Oct 7, 2019
@dennwc dennwc mentioned this pull request Oct 7, 2019
Closed
@dennwc dennwc merged commit 980d103 into cayleygraph:master Oct 7, 2019
@dennwc dennwc deleted the gizmo_filter_err branch October 7, 2019 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dennwc dennwc

Labels
None yet
Projects
None yet
Milestone
v0.7.6
Development

Successfully merging this pull request may close these issues.

Gizmo: Type Assert All Values
1 participant
@dennwc