-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sqlite backend #751
Add sqlite backend #751
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good, I think we can merge it right away. I only want to run tests locally to make sure everything is in order.
Also, can you please update README.md
, ./docs/Configuration.md
and any other places that list supported backends (just search for postgres
in the code)?
Reviewed 8 of 8 files at r1.
Reviewable status: complete! all files reviewed, all discussions resolved
Thanks for the awesome response time :D . I've just pushed some docs. Let me know if you'd like to add anything else. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the documentation! :) Also make sure to add yourself to AUTHORS and CONTRIBUTORS.
All regular tests pass (:tada:), but I've hit an error when running the integration test suite (RUN_INTEGRATION=true go test ./...
). Haven't checked yet what the reason is, though.
Cool, I'll check on that tomorrow |
So here are the failing tests:
No idea why those 3 tests are failing. Each of those take 5 min to run so it's pretty difficult to debug. Might take a while to figure out. EDIT: So I've found that the query timeout for the tests is set to 5 min, which is why all 3 these tests fail at 5 min. I'm not sure how long the other backends take to run these tests, but either sqlite is insanely slow for this case or these test queries are pretty crazy. |
@BrendanBall That might explain why they fail for the same SQL implementation that works for PG and MySQL. I was confused by If setting a higher timeout helps, I will consider this solved. Sure, we might need some optimizations for SQLite to be faster for those kinds of queries, but it's worth merging in the current state as well. |
the test |
OK, I would say that the fact that backend is slow on integration test shouldn't block this PR. We can make some optimizations later, if necessary. I will check the PR again and merge it if there are no objections. |
This change is