fix for deletion of reinserted causing a quad does not exist error #747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dennwc
reviewed
Oct 21, 2018
graph/graphtest/graphtest.go
Outdated
| for i := 0; i < 2; i++ { | ||
| w.AddQuad(quad.Make("<bob>", "<follows>", "<sally>", nil)) | ||
| err = w.RemoveQuad(quad.Make("<bob>", "<follows>", "<sally>", nil)) | ||
| assert.Nil(t, err, "Remove quad failed") |
There was a problem hiding this comment.
Suggested change
| assert.Nil(t, err, "Remove quad failed") | |
| require.NoError(t, err, "Remove quad failed") |
graph/graphtest/graphtest.go
Outdated
| }) | ||
|
|
||
| for i := 0; i < 2; i++ { | ||
| w.AddQuad(quad.Make("<bob>", "<follows>", "<sally>", nil)) |
There was a problem hiding this comment.
Please check an error when adding quads
graph/kv/indexing.go
Outdated
| @@ -675,9 +675,10 @@ func (qs *QuadStore) hasPrimitive(ctx context.Context, tx BucketTx, p *proto.Pri | |||
| if !get && unique { | |||
| return p, nil | |||
| } | |||
| for _, x := range options { | |||
| for ix := len(options) - 1; ix >= 0; ix-- { | |||
There was a problem hiding this comment.
Using i as a name is fine
Suggested change
| for ix := len(options) - 1; ix >= 0; ix-- { | |
| for i := len(options) - 1; i >= 0; i-- { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When reinserting a previously deleted quad, and attempting to then delete it a quad does not exist error was given for the the kv stores, issue was retrieval of the primitive from the log was finding the prviously deleted, not the previously inserted quad. Change retrieval from the log to iterate in reverse to ensure the latest is retrieved when multiple hits. Added unit test.