nquads silently drops lines containing quotes

[kortschak]

If you apply the patch below or equivalent, you see 137 lines output as having been dropped when you execute cayley http --dbpath=30kmoviedata.nt. All have at least one quote (single or double) mark.

    diff --git a/nquads/nquads.go b/nquads/nquads.go
    index 1f534b0..c555cc2 100644
    --- a/nquads/nquads.go
    +++ b/nquads/nquads.go
    @@ -16,6 +16,7 @@ package nquads

     import (
            "bufio"
    +       "fmt"
            "io"
            "strings"

    @@ -185,11 +186,13 @@ func ReadNQuadsFromReader(c chan *graph.Triple, reader io.Reader) {
                            continue
                    }
                    triple := Parse(line)
    -               line = ""
                    if triple != nil {
                            nTriples++
                            c <- triple
    +               } else {
    +                       fmt.Printf("dropped line: %q\n", line)
                    }
    +               line = ""
            }
            glog.Infoln("Read", nTriples, "triples")
            close(c)

[kortschak]

This appears to be merely an issue with the 30kmoviedata.nt dataset (see below) in conjunction with swallowing error conditions. This should be fixed in an upcoming PR from me (this will add error return for cases like this and fix the incorrect 30kmoviedata.nt lines).

$ grep "Weird Al" 30kmoviedata.nt
":/en/the_weird_al_yankovic_video_library" "name" "The "Weird Al" Yankovic Video Library" .
":/en/weird_al_yankovic_live" "name" ""Weird Al" Yankovic Live!" .
":/en/weird_al_yankovic" "name" ""Weird Al" Yankovic" .
":/en/weird_al_yankovic_the_ultimate_collection" "name" ""Weird Al" Yankovic: The Ultimate Collection" .
":/en/weird_al_yankovic_the_ultimate_video_collection" "name" ""Weird Al" Yankovic: The Ultimate Video Collection" .
":/en/weird_al_yankovic_the_videos" "name" ""Weird Al" Yankovic: The Videos" .