accept quad.Value instead of graph.Value for RemoveNode; fix #607

cayleygraph · May 26, 2017 · b3e18e8 · b3e18e8
1 parent 7323095
commit b3e18e8
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/graph/quadwriter.go b/graph/quadwriter.go
@@ -142,7 +142,7 @@ type QuadWriter interface {
 	ApplyTransaction(*Transaction) error
 
 	// RemoveNode removes all quads which have the given node as subject, predicate, object, or label.
-	RemoveNode(Value) error
+	RemoveNode(quad.Value) error
 
 	// Close cleans up replication and closes the writing aspect of the database.
 	Close() error

diff --git a/writer/single.go b/writer/single.go
@@ -103,11 +103,15 @@ func (s *Single) RemoveQuad(q quad.Quad) error {
 }
 
 // RemoveNode removes all quads with the given value
-func (s *Single) RemoveNode(v graph.Value) error {
+func (s *Single) RemoveNode(v quad.Value) error {
+	gv := s.qs.ValueOf(v)
+	if gv == nil {
+		return nil
+	}
 	var deltas []graph.Delta
 	// TODO(dennwc): QuadStore may remove node without iterations. Consider optional interface for this.
 	for _, d := range []quad.Direction{quad.Subject, quad.Predicate, quad.Object, quad.Label} {
-		it := s.qs.QuadIterator(d, v)
+		it := s.qs.QuadIterator(d, gv)
 		for it.Next() {
 			deltas = append(deltas, graph.Delta{
 				ID:        s.currentID.Next(),